Page MenuHomePhabricator

Use OO.ui.confirm() for the confirmation dialog in uw.controller.Details.prototype.valid
Closed, ResolvedPublic

Description

Use OO.ui.confirm() (see https://gerrit.wikimedia.org/r/#/c/257256/ ) for UploadWizard's confirmation dialog in uw.controller.Details.prototype.valid.

Event Timeline

matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
MarkTraceur lowered the priority of this task from Medium to Low.Dec 3 2015, 8:03 PM
MarkTraceur added a project: Technical-Debt.

@matmarex: Am I right that we cannot make this task available yet in GCI because T117076 is not fixed yet?

Yes :/ It always seems like you have more time, until it runs out. I wrote a patch for that bug now, and hopefully it will be merged and available in MediaWiki by Wednesday.

Aklapper set Security to None.

Change 260740 had a related patch set uploaded (by Mhutti1):
Moved uw.controller.Details.prototype.valid to use OO.ui.confirm()

https://gerrit.wikimedia.org/r/260740

Change 260740 merged by jenkins-bot:
Moved uw.controller.Details.prototype.valid to use OO.ui.confirm()

https://gerrit.wikimedia.org/r/260740