Page MenuHomePhabricator

In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file
Closed, ResolvedPublic8 Estimated Story Points

Description

Check https://commons.wikimedia.org/wiki/File:Joe_dirt.jpg which was uploaded using Visual Editor through English Wikipedia according to the edit summary. However, there is already a local file with the same name on English Wikipedia: https://en.wikipedia.org/wiki/File:Joe_dirt.jpg. This means that there currently is no way to use the Commons file on English Wikipedia, but the user who uploaded the file to Commons probably expected it to show up in an article which he was editing. In this situation, Visual Editor should have forced the user to choose a different file name for which there is no filename conflict between enwiki and commonswiki.

Event Timeline

Stefan2 raised the priority of this task from to Needs Triage.
Stefan2 updated the task description. (Show Details)
Stefan2 added a subscriber: Stefan2.
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
Jdforrester-WMF renamed this task from Commons file uploads through Visual Editor should not shadow local files to In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file.Nov 3 2015, 4:29 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subscriber: matmarex.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Change 310880 had a related patch set uploaded (by Matthias Mullie):
[WIP] Validate upload filename

https://gerrit.wikimedia.org/r/310880

Change 310880 merged by jenkins-bot:
mw.ForeignStructuredUpload.BookletLayout: Check upload filename for local duplicates

https://gerrit.wikimedia.org/r/310880

matmarex removed a project: Patch-For-Review.

The user will now see the same error message as if the file existed on Commons.