Maniphest T117816

Adyen payments listener destroys donation info if capture fails
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When a capture request fails for any reason, the Adyen listener deletes all info about the donation from pending and limbo queues. It should only do that when the capture has been declined, not when credentials are wrong or the server is unreachable.

Note: this is suboptimal error handling, but it's not preventing us from processing donations in normal circumstances.

Details

	Subject	Repo	Branch	Lines +/-
	Remove Composer files	data-values/value-view	master	+0 -56
	Don't destroy message on capture error	wikimedia/fundraising/SmashPig	master	+10 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T93302 Big English Fundraiser - December
		Resolved		None	T90748 [epic] Get Adyen back up
		Resolved		None	T118202 [epic] Adyen campaign ready
		Resolved		Ejegg	T117816 Adyen payments listener destroys donation info if capture fails

Event Timeline

Ejegg created this task.Nov 4 2015, 11:54 PM

Ejegg raised the priority of this task from to Needs Triage.

Ejegg updated the task description. (Show Details)

Ejegg added projects: Fundraising-Backlog, FR-Adyen.

Ejegg subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 4 2015, 11:54 PM

Ejegg added a parent task: T118202: [epic] Adyen campaign ready.Nov 9 2015, 10:25 PM

Ejegg updated the task description. (Show Details)

Ejegg set Security to None.

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Dec 9 2015, 10:08 PM

• DStrine moved this task from Sprint +1 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Dec 9 2015, 11:51 PM

• DStrine added a project: Fundraising Sprint Zapp.Dec 9 2015, 11:57 PM

awight removed a project: Fundraising Sprint Zapp.Dec 23 2015, 11:08 PM

• DStrine added a project: Fundraising Sprint Asbestos Removal 2016.Jan 11 2016, 6:02 PM

• DStrine moved this task from Closed Sprint Work Completed in Q2 1516 to Current Sprint & Completed in Q3 1516 on the Fundraising-Backlog board.Jan 12 2016, 5:42 PM

• DStrine added a project: Fundraising Sprint Bloodletting 2016.Jan 20 2016, 11:51 PM

Change 268025 had a related patch set uploaded (by Ejegg):
Don't destroy message on capture error

https://gerrit.wikimedia.org/r/268025

gerritbot added a project: Patch-For-Review.Feb 3 2016, 12:00 AM

Ejegg claimed this task.Feb 3 2016, 12:00 AM

Ejegg edited a custom field.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Bloodletting 2016 board.

• DStrine added a project: Fundraising Sprint Cat Herding.Feb 3 2016, 11:40 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Cat Herding board.Feb 4 2016, 12:07 AM

Change 268025 merged by Ejegg:
Don't destroy message on capture error

https://gerrit.wikimedia.org/r/268025

Eileenmcnaughton moved this task from Review to Pending Deployment on the Fundraising Sprint Cat Herding board.Feb 11 2016, 12:41 AM

• DStrine added a project: Fundraising Sprint Dirt Farming.Feb 17 2016, 11:49 PM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Dirt Farming board.Feb 18 2016, 12:05 AM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Dirt Farming board.Feb 24 2016, 7:53 PM

Ejegg closed this task as Resolved.Mar 2 2016, 11:31 PM

Change 383861 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[data-values/value-view@master] Remove Composer files

https://gerrit.wikimedia.org/r/383861

Change 383861 merged by jenkins-bot:
[data-values/value-view@master] Remove Composer files

https://gerrit.wikimedia.org/r/383861