Page MenuHomePhabricator
Create Task
Maniphest T118152

Switch to VE button presented on Create page but doesn't function
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Take: https://simple.wikipedia.org/w/index.php?title=Sjdljfa&action=edit

On this page, the VE button is presented, but you cannot actually create pages here

Details

SubjectRepoBranchLines +/-
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages workmediawiki/extensions/VisualEditorwmf/1.27.0-wmf.5+6 -2
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages workmediawiki/extensions/VisualEditormaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Nov 9 2015, 10:00 AM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: VisualEditor, WikiEditor (2010), VisualEditor-MediaWiki.
TheDJ subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 9 2015, 10:00 AM
Krenair closed this task as a duplicate of T118070: Consider accepting the empty string for required parameters (esp. wikitext).Nov 9 2015, 12:53 PM
TheDJ added a comment.Nov 9 2015, 3:02 PM

Wouldn't it be handier to set this ticket as "blocked by" instead of duplicate ?
Separating the higher level user story from the technical details.

Krenair subscribed.Nov 9 2015, 5:03 PM

Not if they end up being fixed by the same change...

matmarex reopened this task as Open.Nov 9 2015, 5:45 PM
matmarex subscribed.

This is so not a duplicate, and should be fixed in VE regardless of RESTBase problems.

Krenair added a comment.Nov 9 2015, 5:51 PM

You mean special cased in VE because RESTBase can't handle it?

gerritbot subscribed.Nov 9 2015, 5:55 PM

Change 252014 had a related patch set uploaded (by Bartosz Dziewoński):
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work

https://gerrit.wikimedia.org/r/252014

gerritbot added a project: Patch-For-Review.Nov 9 2015, 5:55 PM
matmarex triaged this task as Unbreak Now! priority.Nov 9 2015, 5:55 PM

This literally prevents users from starting new articles using VE. I think it deserves higher priority.

matmarex mentioned this in T118070: Consider accepting the empty string for required parameters (esp. wikitext).Nov 9 2015, 5:57 PM
Krenair closed this task as a duplicate of T118070: Consider accepting the empty string for required parameters (esp. wikitext).Nov 9 2015, 6:00 PM
gerritbot added a comment.Nov 9 2015, 10:42 PM

Change 252014 merged by Alex Monk:
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work

https://gerrit.wikimedia.org/r/252014

gerritbot added a comment.Nov 9 2015, 10:48 PM

Change 252123 had a related patch set uploaded (by Jforrester):
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work

https://gerrit.wikimedia.org/r/252123

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 9 2015, 11:00 PM
gerritbot added a comment.Nov 10 2015, 4:23 PM

Change 252123 merged by Jforrester:
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work

https://gerrit.wikimedia.org/r/252123

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 10 2015, 5:00 PM
Jdforrester-WMF changed the task status from Duplicate to Resolved.Nov 10 2015, 6:31 PM
Jdforrester-WMF claimed this task.
matmarex added a comment.Nov 11 2015, 8:14 PM

T118070 should be fixed now, should we revert the workaround on master?

Jdforrester-WMF added a comment.Nov 11 2015, 8:15 PM
In T118152#1799699, @matmarex wrote:

T118070 should be fixed now, should we revert the workaround on master?

We did: https://www.mediawiki.org/wiki/ThisPageDoesNotExist?action=edit

matmarex added a comment.Nov 11 2015, 8:54 PM

Pretty sure we didn't. That page still has the behavior I implemented in the workaround from this task.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Nov 16 2015, 6:52 PM
In T118152#1799800, @matmarex wrote:

Pretty sure we didn't. That page still has the behavior I implemented in the workaround from this task.

That's the fix, yes.

Jdforrester-WMF reassigned this task from Jdforrester-WMF to matmarex.Nov 16 2015, 6:53 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
GOIII moved this task from Backlog to Closed on the WikiEditor (2010) board.Apr 3 2016, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits