Page MenuHomePhabricator

[Bug] Editing a qualifier in a group of qualifiers shows the other ones as recreated in diff
Closed, ResolvedPublic

Description

If a statement has a collection of qualifiers, and one edits any of those qualifiers, all unchanged qualifiers will show up in the resulting diff as having been deleted, with new identical qualifiers created separately.

Event Timeline

Yair_rand raised the priority of this task from to Needs Triage.
Yair_rand updated the task description. (Show Details)
Yair_rand added a project: Wikidata.
Yair_rand subscribed.
Jonas renamed this task from Editing any qualifiers recreates all existing qualifiers to [Bug] Editing any qualifiers recreates all existing qualifiers.Dec 14 2015, 11:31 AM
Jonas set Security to None.
Jonas added a subscriber: Lydia_Pintscher.
Jonas subscribed.
Lydia_Pintscher renamed this task from [Bug] Editing any qualifiers recreates all existing qualifiers to [Bug] Editing a qualifier in a group of qualifiers shows the other ones as recreated in diff.Mar 16 2016, 10:00 AM
Lydia_Pintscher triaged this task as High priority.

Now that we are managing property constraints in statements, this problem has become more visible. See for instance this diff (the edit summary doesn't help either). (Although you can sometimes assume it's a new qualifier, thus the bottom one.)

matej_suchanek lowered the priority of this task from High to Low.Dec 24 2017, 1:50 PM
matej_suchanek added a project: TestMe.

Hm, now when I take a look at the diff, it looks perfect. Unless someone finds another problem, I suppose we can close this.

Lydia_Pintscher claimed this task.

Yay :)
Probably fixed as a sideeffect of Amir's work on compact diffs.