Page MenuHomePhabricator

mwext-qunit tests fails for wmf5 branch
Closed, ResolvedPublic

Description

CX and VE fails to pass mwext-qunit tests for unrelated reason. Filing bug based on discussion at #wikimedia-releng. Marking as high as it blocks merging code for SWAT today!

11:38 hashar+: kart_: yeah the qunit jobs are somehow hit by a race condition                                                                                                                        
11:38 +hashar: or suffers from slaves being overloaded                                                                                                                                                      
11:38 kart_ : oh.                                                                                                                                                                                   
11:38 kart_ : Should I do recheck after some time?                                                                                                                                                  
11:38 +hashar: hard to investigate :-(                                                                                                                                                                      
11:38 +hashar: yeah just recheck                                                                                                                                                                            
11:38 +hashar: and hope :-(                                                                                                                                                                                 
11:38 kart_ : hashar: force merge is fine then?                                                                                                                                                     
11:38 +hashar: I have nothing better to offer sorry                                                                                                                                                         
11:39 kart_ : hashar: no problem.                                                                                                                                                                   
11:39 +hashar: force merges kills zuul                                                                                                                                                                      
11:39 +hashar: there are bunch of exceptions https://integration.wikimedia.org/ci/job/mwext-qunit/7757/artifact/log/mw-error.log/*view*/                                                                    
11:39 +hashar: maybe unrelated                                                                                                                                                                              
11:39 +hashar: PHP Warning: Cannot modify header information - headers ...                                                                                                                                  
11:40 +hashar: and a bunch of errors on the server side https://integration.wikimedia.org/ci/job/mwext-qunit/7757/artifact/log/mw-debug-www.log/*view*/                                                     
11:40 +hashar: [DBPerformance] Expectation (writes <= 0) by MediaWiki::main not met:                                                                                                                        
11:40 +hashar: query-m: DELETE FROM `l10n_cache` WHERE lc_lang = 'X' [TRX#a7cd3555976d]                                                                                                                     
11:40 +hashar: seems the database back end is too slow                                                                                                                                                      
11:40 kart_ : hashar: has bug for that? :)                                                                                                                                                          
11:40 +hashar: nop

Event Timeline

KartikMistry raised the priority of this task from to High.
KartikMistry updated the task description. (Show Details)

From a discussion with @JanZerebecki today:

Warning: include_once(/mnt/jenkins-workspace/workspace/mwext-qunit/src/extensions/Wikidata/extensions/ExternalValidation/WikibaseQualityExternalValidation.php): failed to open stream: No such file or directory in /mnt/jenkins-workspace/workspace/mwext-qunit/src/extensions/Wikidata/Wikidata.php on line <i>42</i></th></tr>

Which is an issue in wikidata and how it handles custom configuration for the CI runs apparently.

Change 252227 had a related patch set uploaded (by JanZerebecki):
Don't try to load WikidataQualityExternalValidation in CI.

https://gerrit.wikimedia.org/r/252227

Change 252227 merged by jenkins-bot:
Don't try to load WikidataQualityExternalValidation in CI.

https://gerrit.wikimedia.org/r/252227

We confirmed the ContentTranslation qunit tests are fixed by editing https://gerrit.wikimedia.org/r/#/c/252172/ and making it depends on the Wikibase change above https://gerrit.wikimedia.org/r/252227 . The trick was to amend the commit message to reference the Wikibase change:

+ Depends-On: I0312c23628d706deb507b5534b868480945b6163

https://gerrit.wikimedia.org/r/#/c/252172/1..2//COMMIT_MSG