Page MenuHomePhabricator
Create Task
Maniphest T118420

Wrong arguments passed to DatabaseOracle::__construct() from OracleInstaller.php
Closed, ResolvedPublic
Actions

Description

Issue reported in Topic:Ssi9icj9pkg30z8e:

PHP Catchable fatal error: Argument 1 passed to DatabaseOracle::__construct() must be an array, string given,
called in /mediawiki/app/includes/installer/OracleInstaller.php on line 176 and defined in /mediawiki/app/includes/db/DatabaseOracle.php on line 210

Indeed, constructor of DatabaseOracle is:

function __construct( array $p ) {

but OracleInstaller uses:

$db = new DatabaseOracle(
        $this->getVar( 'wgDBserver' ),
        $this->getVar( '_InstallUser' ),
        $this->getVar( '_InstallPassword' ),
        $this->getVar( '_InstallDBname' ),
        0,
        $this->getVar( 'wgDBprefix' )
);

This happens on MediaWiki 1.25 at least

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix bogus DatabaseOracle::__construct() calls in OracleInstallermediawiki/coreREL1_29+21 -24
Fix bogus DatabaseOracle::__construct() calls in OracleInstallermediawiki/coreREL1_30+20 -24
Fix bogus DatabaseOracle::__construct() calls in OracleInstallermediawiki/coreREL1_27+20 -24
Customize query in gerrit

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Nov 11 2015, 9:11 PM
Ciencia_Al_Poder raised the priority of this task from to Needs Triage.
Ciencia_Al_Poder updated the task description. (Show Details)
Ciencia_Al_Poder added a project: MediaWiki-Installer.
Ciencia_Al_Poder subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 11 2015, 9:11 PM
Ciencia_Al_Poder added a parent task: T40916: [DO NOT USE] Oracle DB support (tracking).Nov 11 2015, 9:12 PM
tstarling added a project: Oracle Database.May 19 2017, 10:16 AM
tstarling removed a parent task: T40916: [DO NOT USE] Oracle DB support (tracking).May 19 2017, 10:21 AM
Fheredia subscribed.Jun 13 2018, 2:45 PM
Fheredia added a comment.Jun 28 2018, 8:16 PM

Somebody is working on..? I want to collaborate...! Thanks a lot.

Fheredia added a comment.Jun 28 2018, 8:28 PM

My starting work:

1.- turn string given into array:

$db = new DatabaseOracle(
array('wgDBserver' => $this->getVar( 'wgDBserver' ),
'_InstallUser' => $this->getVar( '_InstallUser' ),
'_InstallPassword' => $this->getVar( '_InstallPassword' ),
'_InstallDBname' => $this->getVar( '_InstallDBname' ),
'0' => 0,
'tablePrefix' => $this->getVar( 'wgDBprefix' ))
);

2.- analyze generated errors:
URL: http://localhost/mediawiki130/mw-config/index.php?page=DBConnect

GIVEN ARRAY: array(6) { ["wgDBserver"]=> string(11) "tnsname.ora" ["_InstallUser"]=> string(4) "WIKI" ["_InstallPassword"]=> string(8) "xxxxxxxxxxx" ["_InstallDBname"]=> string(4) "WIKI" [0]=> int(0) ["wgDBprefix"]=> string(6) "MW130_" }

GENERATED ERR:
Notice: Undefined index: tablePrefix in C:\xampp\htdocs\mediawiki130\includes\db\DatabaseOracle.php on line 55
Notice: Undefined index: tablePrefix in C:\xampp\htdocs\mediawiki130\includes\db\DatabaseOracle.php on line 58
(well, this two were predictable...)
Notice: Undefined index: host in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 248
Notice: Undefined index: user in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 249
Notice: Undefined index: password in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 250
Notice: Undefined index: dbname in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 251
Notice: Undefined index: schema in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 253
Notice: Undefined index: cliMode in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 256
Notice: Undefined index: agent in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 258
Notice: Undefined index: flags in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 260
Notice: Undefined index: variables in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 269
Notice: Undefined index: profiler in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 275
Notice: Undefined index: trxProfiler in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 276
Notice: Undefined index: connLogger in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 277
Notice: Undefined index: queryLogger in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 278
Notice: Undefined index: errorLogger in C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php on line 279

[228d4e577d07dd5d6bc58cdb] /mediawiki130/mw-config/index.php?page=DBConnect InvalidArgumentException from line 287 of C:\xampp\htdocs\mediawiki130\includes\libs\rdbms\database\Database.php: No database user provided.

BACKTRACE:
#0 C:\xampp\htdocs\mediawiki130\includes\db\DatabaseOracle.php(59): Wikimedia\Rdbms\Database->construct(array)
#1 C:\xampp\htdocs\mediawiki130\includes\installer\OracleInstaller.php(185): DatabaseOracle->construct(array)
#2 C:\xampp\htdocs\mediawiki130\includes\installer\DatabaseInstaller.php(184): OracleInstaller->openConnection()
#3 C:\xampp\htdocs\mediawiki130\includes\installer\OracleInstaller.php(128): DatabaseInstaller->getConnection()
#4 C:\xampp\htdocs\mediawiki130\includes\installer\WebInstallerDBConnect.php(118): OracleInstaller->submitConnectForm()
#5 C:\xampp\htdocs\mediawiki130\includes\installer\WebInstallerDBConnect.php(34): WebInstallerDBConnect->submit()
#6 C:\xampp\htdocs\mediawiki130\includes\installer\WebInstaller.php(277): WebInstallerDBConnect->execute()
#7 C:\xampp\htdocs\mediawiki130\mw-config\index.php(80): WebInstaller->execute(array)
#8 C:\xampp\htdocs\mediawiki130\mw-config\index.php(39): wfInstallerMain()
#9 {main}

PLEASE: Could anybody point me to includes\libs\rdbms\database\Database.php documentation...? TIA..!

Krinkle added projects: MW-1.30-release, MW-1.31-release, MW-1.32-release.Jun 28 2018, 8:36 PM
Krinkle subscribed.

@Fheredia The generated documentation for that file is at https://doc.wikimedia.org/mediawiki-core/1.30.0/php/classWikimedia_1_1Rdbms_1_1Database.html.

As for the file in Git, it is there, but it is in IDatabase.php instead of Database.php. See libs/rdbms/database/IDatabase.php.

Krinkle added a project: MediaWiki-libs-Rdbms.Jun 28 2018, 8:36 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Legoktm assigned this task to aaron.Aug 29 2018, 2:08 AM
Legoktm removed projects: MW-1.32-release, MW-1.31-release.
Legoktm subscribed.

Aaron fixed this in rMW6120c18829d7: Fix bogus DatabaseOracle::__construct() calls in OracleInstaller, so this is only an issue in pre-1.31.

Legoktm added projects: MW-1.27-release, MW-1.29-release.Aug 29 2018, 2:11 AM

rMW2cfcb390c67a: DatabaseBase constructor cleanups (1.25) introduced the problem, so we also need backports to 1.27 and 1.29.

gerritbot subscribed.Aug 29 2018, 5:56 AM

Change 456077 had a related patch set uploaded (by Legoktm; owner: Aaron Schulz):
[mediawiki/core@REL1_27] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456077

gerritbot added a project: Patch-For-Review.Aug 29 2018, 5:56 AM

Change 456076 had a related patch set uploaded (by Legoktm; owner: Aaron Schulz):
[mediawiki/core@REL1_29] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456076

gerritbot added a comment.Aug 29 2018, 5:57 AM

Change 456075 had a related patch set uploaded (by Legoktm; owner: Aaron Schulz):
[mediawiki/core@REL1_30] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456075

gerritbot added a comment.Aug 29 2018, 7:01 PM

Change 456075 merged by jenkins-bot:
[mediawiki/core@REL1_30] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456075

gerritbot added a comment.Aug 29 2018, 7:14 PM

Change 456077 merged by jenkins-bot:
[mediawiki/core@REL1_27] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456077

gerritbot added a comment.Aug 29 2018, 7:19 PM

Change 456076 merged by jenkins-bot:
[mediawiki/core@REL1_29] Fix bogus DatabaseOracle::__construct() calls in OracleInstaller

https://gerrit.wikimedia.org/r/456076

Legoktm closed this task as Resolved.Aug 29 2018, 7:57 PM
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.30-release-notes, MW-1.29-release-notes.Aug 29 2018, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits