Page MenuHomePhabricator
Create Task
Maniphest T118662

GUC tool always outputs "searched 1 projects" instead of actual count
Closed, ResolvedPublic
Actions

Description

In users that have edits to more than one wiki, the tool still shows "in 1 projects".

Selection_019.png (536×816 px, 44 KB)

Details

SubjectRepoBranchLines +/-
guc: Fix broken display of projects with non-zero editslabs/tools/gucmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MC8 created this task.Nov 14 2015, 10:29 PM
MC8 raised the priority of this task from to Needs Triage.
MC8 updated the task description. (Show Details)
MC8 added a project: Tool-Global-user-contributions.
MC8 subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 14 2015, 10:29 PM
Krinkle merged a task: T123879: GUC project total count doesn't increment.May 16 2016, 1:21 PM
Krinkle added subscribers: Danny_B, Devirk.
Krinkle set Security to None.May 16 2016, 1:24 PM
Krinkle added a subscriber: • Elitre.
Danny_B renamed this task from Tool no longer shows number of projects with edits to GUC project total count doesn't increment.May 16 2016, 2:59 PM
Danny_B assigned this task to Devirk.
Danny_B triaged this task as Low priority.
Danny_B added projects: good first task, JavaScript.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 16 2016, 2:59 PM
Krinkle removed a project: JavaScript.May 16 2016, 3:31 PM
Krinkle subscribed.

"count doesn't increment" inaccurately summarises the problem and makes assumptions about what the underlying bug is.

Krinkle renamed this task from GUC project total count doesn't increment to GUC tool always outputs "searched 1 projects" instead of actual count.May 16 2016, 3:33 PM
Krinkle added a project: Regression.
Danny_B added a comment.May 16 2016, 5:17 PM

@Krinkle Thanks for title clarification.

Why did you remove JavaScript actually?

Glaisher subscribed.May 16 2016, 5:20 PM

It's generated on the PHP side.

Danny_B added a comment.May 17 2016, 8:11 AM

Thanks. I thought the counter increases via JS as one would expect it...

Krinkle moved this task from Inbox to Accepted Enhancement on the Tool-Global-user-contributions board.Jul 11 2016, 9:59 PM
Krinkle moved this task from Accepted Enhancement to Confirmed Problem on the Tool-Global-user-contributions board.
gerritbot subscribed.Aug 31 2016, 2:38 AM

Change 307678 had a related patch set uploaded (by Krinkle):
guc: Fix broken display of projects with non-zero edits

https://gerrit.wikimedia.org/r/307678

gerritbot added a project: Patch-For-Review.Aug 31 2016, 2:38 AM
Krinkle claimed this task.Aug 31 2016, 2:39 AM
Krinkle removed a project: good first task.
gerritbot added a comment.Aug 31 2016, 2:40 AM

Change 307678 merged by Krinkle:
guc: Fix broken display of projects with non-zero edits

https://gerrit.wikimedia.org/r/307678

Krinkle closed this task as Resolved.Aug 31 2016, 2:40 AM
Krinkle removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL