Page MenuHomePhabricator
Create Task
Maniphest T118813

Only load vega.js upon opening graph edit dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Vega is currently always being loaded by VisualEditor even though the vast majority of pages not containing graphs.

Details

SubjectRepoBranchLines +/-
Only load Vega with VE on pages containing graphsmediawiki/extensions/Graphmaster+16 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• ferdbold created this task.Nov 17 2015, 1:55 AM
• ferdbold raised the priority of this task from to High.
• ferdbold updated the task description. (Show Details)
• ferdbold added projects: Graph-VisualEditor, VisualEditor.
• ferdbold moved this task to Backlog on the Graph-VisualEditor board.
• ferdbold subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2015, 1:55 AM
• ferdbold renamed this task from Only load vega.js upon opening graph editing dialog to Only load vega.js upon opening graph edit dialog.Nov 17 2015, 1:55 AM
• ferdbold set Security to None.
Jdforrester-WMF added a project: Performance Issue.Nov 17 2015, 2:02 AM
Jdforrester-WMF edited a custom field.
Krenair subscribed.Nov 17 2015, 2:18 AM
• MZMcBride subscribed.Nov 17 2015, 4:27 AM
Esanders moved this task from To Triage to Blocked on the VisualEditor board.Nov 17 2015, 5:33 AM
• ferdbold moved this task from Backlog to In Progress on the Graph-VisualEditor board.Nov 17 2015, 6:31 PM
• ferdbold claimed this task.Nov 17 2015, 6:57 PM
gerritbot subscribed.Nov 17 2015, 7:30 PM

Change 253655 had a related patch set uploaded (by Ferdbold):
Only load Vega with VE on pages containing graphs

https://gerrit.wikimedia.org/r/253655

gerritbot added a project: Patch-For-Review.Nov 17 2015, 7:30 PM
• ferdbold moved this task from In Progress to For review on the Graph-VisualEditor board.Nov 17 2015, 7:32 PM
gerritbot added a comment.Nov 17 2015, 7:34 PM

Change 253655 merged by jenkins-bot:
Only load Vega with VE on pages containing graphs

https://gerrit.wikimedia.org/r/253655

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 17 2015, 8:00 PM
• ferdbold closed this task as Resolved.Nov 17 2015, 8:08 PM
• ferdbold moved this task from For review to Merged on the Graph-VisualEditor board.
Jdforrester-WMF added a project: MediaWiki-extensions-Graph.Nov 20 2015, 8:04 PM
Jdforrester-WMF added a parent task: T119233: [Objective] It's easier to create and edit charts from within VisualEditor.Nov 20 2015, 9:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL