Page MenuHomePhabricator

"Select a file" does not appear localized in the VisualEditor
Closed, ResolvedPublic1 Story Points

Description

There seems to be a message for it, but it's not actually used.

Screenshot:

I'd commit a patch myself, but it's a bit different in oojsui - I hope to learn for the next time ;)

Event Timeline

Amire80 created this task.Nov 21 2015, 7:55 PM
Amire80 raised the priority of this task from to Normal.
Amire80 updated the task description. (Show Details)
Amire80 added projects: I18n, VisualEditor, OOUI.
Amire80 added a subscriber: Amire80.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2015, 7:55 PM
Amire80 renamed this task from "Selext a file" does not appear localized in the VisualEditor to "Select a file" does not appear localized in the VisualEditor.Nov 21 2015, 7:57 PM
Amire80 set Security to None.

Oops... we actually have the message but forgot to use it.

Change 254669 had a related patch set uploaded (by Esanders):
SelectFileWidget: Use i18n string for button label

https://gerrit.wikimedia.org/r/254669

Jdforrester-WMF closed this task as Resolved.Nov 21 2015, 10:56 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.

Change 254669 merged by jenkins-bot:
SelectFileWidget: Use i18n string for button label

https://gerrit.wikimedia.org/r/254669

Thank you for the quick fix!

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jan 7 2016, 4:05 AM