Page MenuHomePhabricator
Create Task
Maniphest T119307

"Select a file" does not appear localized in the VisualEditor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

There seems to be a message for it, but it's not actually used.

Screenshot:

select-a-file.png (733×1 px, 143 KB)

I'd commit a patch myself, but it's a bit different in oojsui - I hope to learn for the next time ;)

Details

SubjectRepoBranchLines +/-
SelectFileWidget: Use i18n string for button labeloojs/uimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Nov 21 2015, 7:55 PM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: I18n, VisualEditor, OOUI.
Amire80 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2015, 7:55 PM
Amire80 renamed this task from "Selext a file" does not appear localized in the VisualEditor to "Select a file" does not appear localized in the VisualEditor.Nov 21 2015, 7:57 PM
Amire80 set Security to None.
Esanders subscribed.Nov 21 2015, 10:42 PM

Oops... we actually have the message but forgot to use it.

gerritbot subscribed.Nov 21 2015, 10:42 PM

Change 254669 had a related patch set uploaded (by Esanders):
SelectFileWidget: Use i18n string for button label

https://gerrit.wikimedia.org/r/254669

gerritbot added a project: Patch-For-Review.Nov 21 2015, 10:42 PM
Jdforrester-WMF closed this task as Resolved.Nov 21 2015, 10:56 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Nov 21 2015, 11:02 PM

Change 254669 merged by jenkins-bot:
SelectFileWidget: Use i18n string for button label

https://gerrit.wikimedia.org/r/254669

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.14.0), MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed OOjs-UI-next-release.Nov 25 2015, 2:31 AM
Amire80 added a comment.Nov 30 2015, 12:55 PM

Thank you for the quick fix!

Amire80 awarded a token.Nov 30 2015, 12:55 PM
Amire80 mentioned this in T119984: "Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor.Dec 1 2015, 5:32 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Dec 3 2015, 1:11 AM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jan 7 2016, 4:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL