Page MenuHomePhabricator

"Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor
Closed, ResolvedPublic

Description

When I open the new Upload OOJS-ui dialog in the wiki in the Hebrew Wikipedia, the strings "Select a file" and "No file is selected" are not translated, even though I'm pretty sure that they were translated in translatewiki a while ago.

This may or may not be related to T119307.

Details

Related Gerrit Patches:

Event Timeline

Amire80 created this task.Dec 1 2015, 5:32 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: I18n, VisualEditor, OOUI.
Amire80 added subscribers: Amire80, matmarex.
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald TranscriptDec 1 2015, 5:32 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptDec 1 2015, 7:11 PM

OOjs UI code uses OO.ui.msg() to produce localised messages. Within MediaWiki, that method should be equivalent to mw.msg() (normally, it just takes English strings from a hard-coded list)… but it's not.

We have somehow managed not to implement this during the past two years or so when it could've been needed. It only works within VisualEditor (because it has yet another localisation message implementation when running standalone).

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 1 2015, 7:17 PM
matmarex claimed this task.Dec 1 2015, 7:17 PM

This is neither a WikiEditor or a Multimedia problem. This is a VisualEditor problem because it has a hack for this issue which will need to be removed when I resolve it.

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 1 2015, 7:42 PM
matmarex triaged this task as High priority.Dec 1 2015, 7:46 PM

Change 256436 had a related patch set uploaded (by Bartosz Dziewoński):
Connect OOjs UI to MediaWiki's localisation system

https://gerrit.wikimedia.org/r/256436

Change 256436 merged by jenkins-bot:
Connect OOjs UI to MediaWiki's localisation system

https://gerrit.wikimedia.org/r/256436

Change 256459 had a related patch set uploaded (by Jforrester):
Connect OOjs UI to MediaWiki's localisation system

https://gerrit.wikimedia.org/r/256459

matmarex closed this task as Resolved.Dec 2 2015, 6:39 PM

Change 256459 merged by jenkins-bot:
Connect OOjs UI to MediaWiki's localisation system

https://gerrit.wikimedia.org/r/256459