Page MenuHomePhabricator
Create Task
Maniphest T119585

Create a state dropdown for Mustache forms
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

RapidHTML forms have a <select> for states/provinces, while Mustache forms only have a text box so far.

Details

SubjectRepoBranchLines +/-
add state dropdown to mustache formmediawiki/extensions/DonationInterfacemaster+60 -1
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Nov 25 2015, 12:28 AM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: MediaWiki-extensions-DonationInterface, Fundraising-Backlog.
Ejegg subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 25 2015, 12:28 AM
• atgo subscribed.Nov 25 2015, 6:49 PM

hey @Ejegg is this a long term thing or something we need for adyen?

Ejegg added a comment.Nov 25 2015, 6:49 PM

It's a nice-to-have for Adyen

• DStrine moved this task from Triage to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Nov 25 2015, 11:59 PM
• DStrine added a project: Fundraising Sprint Yo La Tengo.Nov 26 2015, 12:20 AM
awight moved this task from Backlog to Doing on the Fundraising Sprint Yo La Tengo board.Dec 3 2015, 12:39 AM
awight moved this task from Doing to Backlog on the Fundraising Sprint Yo La Tengo board.Dec 4 2015, 8:00 PM
• DStrine added a project: Fundraising Sprint Zapp.Dec 9 2015, 11:57 PM
• cwdent claimed this task.Dec 10 2015, 12:57 AM
• cwdent moved this task from Backlog to Review on the Fundraising Sprint Zapp board.
• cwdent set Security to None.
gerritbot subscribed.Dec 10 2015, 12:59 AM

Change 258080 had a related patch set uploaded (by Cdentinger):
fiddle with iframe container/content height

https://gerrit.wikimedia.org/r/258080

gerritbot added a project: Patch-For-Review.Dec 10 2015, 12:59 AM
awight moved this task from Review to Doing on the Fundraising Sprint Zapp board.Dec 10 2015, 1:02 AM
• cwdent added a subscriber: awight.Dec 14 2015, 10:22 PM

@awight T120992 has a small start on doing some for real L10N on the mustache forms, but it seems like we might want to wedge this in for US in the time being. Do you have thoughts on that?

• cwdent edited a custom field.Dec 14 2015, 10:37 PM
awight added a comment.Dec 14 2015, 10:43 PM

@cwdent
I'm happy with any degree of provisional wedging, in this case--my only objection in CR was that the state dropdown should be conditional so that it only appears for countries that it supports (US).

gerritbot added a comment.Dec 14 2015, 11:29 PM

Change 258075 had a related patch set uploaded (by Cdentinger):
add state dropdown to mustache form

https://gerrit.wikimedia.org/r/258075

• cwdent moved this task from Doing to Review on the Fundraising Sprint Zapp board.Dec 18 2015, 8:39 PM
gerritbot added a comment.Dec 21 2015, 7:23 PM

Change 258075 merged by jenkins-bot:
add state dropdown to mustache form

https://gerrit.wikimedia.org/r/258075

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 21 2015, 8:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Zapp board.Dec 21 2015, 9:18 PM
• cwdent closed this task as Resolved.Dec 22 2015, 12:31 AM
• cwdent moved this task from Pending Deployment to Done on the Fundraising Sprint Zapp board.
• mmodell removed a subscriber: awight.Jun 22 2017, 9:43 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits