Maniphest T119802

Incorrect params list in transclusion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Nov 28 2015, 7:54 PM

Description

{{echo|[[File:Image-x-generic.svg|right|140px|link=]]}}
{{echo|[[File:Image-x-generic.svg|right|140px|link=x]]}}

Looking at data-mw for the above two transclusions, we see the following:

"params":{"1":{"wt":"[[File:Image-x-generic.svg"},"2":{"wt":"right"},"3":{"wt":"140px"},"link":{"wt":"]]"}}
vs
"params":{"1":{"wt":"[[File:Image-x-generic.svg|right|140px|link=x]]"}}

The peg tokens are not to fault. Looks like it might be something in ext.core.TemplateHandler that sets up params.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T119706 empty link parameter inside image transclusion inside a templates breaks the Template editor
		Resolved		Arlolra	T119802 Incorrect params list in transclusion

Event Timeline

ssastry created this task.Nov 28 2015, 7:54 PM

ssastry raised the priority of this task from to Medium.

ssastry updated the task description. (Show Details)

ssastry added a project: Parsoid.

ssastry subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2015, 7:54 PM

ssastry updated the task description. (Show Details)Nov 28 2015, 7:55 PM

ssastry set Security to None.

Ricordisamoa subscribed.Nov 28 2015, 9:20 PM

TheDJ added a parent task: T119706: empty link parameter inside image transclusion inside a templates breaks the Template editor.Nov 30 2015, 4:43 PM

Change 367807 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T119802: Fix parse of empty param in link in template param

https://gerrit.wikimedia.org/r/367807

gerritbot added a project: Patch-For-Review.Jul 25 2017, 9:31 PM

Change 367807 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T119802: Fix parse of empty param in link in template param

https://gerrit.wikimedia.org/r/367807

Arlolra closed this task as Resolved.Jul 25 2017, 10:44 PM

Arlolra claimed this task.

Mentioned in SAL (#wikimedia-operations) [2017-08-03T18:03:38Z] <arlolra> Updated Parsoid to 651f12c2 (T119802, T73386, T170289)