Page MenuHomePhabricator

CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable
Closed, ResolvedPublic1 Story Points

Description

This would let you close a banner but get another poke sooner than you would with the normal close button (which currently keeps us at bay for a full 7 days).

Event Timeline

AndyRussG created this task.Dec 2 2015, 3:34 AM
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG moved this task to Triage on the Fundraising-Backlog board.
AndyRussG added a subscriber: AndyRussG.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 2 2015, 3:34 AM
Pcoombe updated the task description. (Show Details)Dec 2 2015, 11:57 AM
Pcoombe set Security to None.

Hey @AndyRussG, @Pcoombe & @atgo

Thanks for looking into this. Bummer there's not an easy way to do this in the banner, we thought there would be a simple solution to test it out. Do you have an idea if this would be a significant amount of work? We would like to use it for a test, but I think it might actually be something we would roll out across the campaign. We're getting a lot of banner closes and I think (but don't know for sure how many) of those closes are from people who were busy but who might want to donate later. It could be good for us to be able to better hide banners from people who really don't want to donate and still give a chance to those who do want to donate. If this is the type of thing that could break a bunch on stuff in central notice, let's hold off :) Thanks for your input!

Do you have an idea if this would be a significant amount of work?
[...]
If this is the type of thing that could break a bunch on stuff in central notice, let's hold off :) Thanks for your input!

Hi! On the contrary, it would be quick, simple and safe, I think! We're already planning a small deploy (to make the 'namespace' hide reason handled by banner history minification) so that could potentially go out at the same time...

Quick, simple, safe!? That's great to hear. Wow. Need any other info from us?

atgo added a comment.Dec 2 2015, 2:48 PM

@AndyRussG can you put an estimate on this?

AndyRussG edited a custom field.Dec 2 2015, 3:37 PM

Change 256615 had a related patch set uploaded (by AndyRussG):
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256615

With this patch, we have a hard-coded 1-month limit to the duration of custom hide cookies, just as a precaution against cookie proliferation.

Change 256615 merged by jenkins-bot:
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256615

Change 256863 had a related patch set uploaded (by AndyRussG):
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256863

Change 256863 merged by jenkins-bot:
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256863

AndyRussG closed this task as Resolved.Dec 4 2015, 1:43 AM
AndyRussG reopened this task as Open.
AndyRussG closed this task as Resolved.Dec 4 2015, 1:46 AM