Page MenuHomePhabricator
Create Task
Maniphest T120056

CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This would let you close a banner but get another poke sooner than you would with the normal close button (which currently keeps us at bay for a full 7 days).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ext.centralNotice.display: Add API for custom hide cookie reasons and durationsmediawiki/extensions/CentralNoticewmf_deploy+50 -9
ext.centralNotice.display: Add API for custom hide cookie reasons and durationsmediawiki/extensions/CentralNoticemaster+50 -9
Customize query in gerrit

Event Timeline

• AndyRussG created this task.Dec 2 2015, 3:34 AM
• AndyRussG raised the priority of this task from to Needs Triage.
• AndyRussG updated the task description. (Show Details)
• AndyRussG added projects: Fundraising-Backlog, MediaWiki-extensions-CentralNotice.
• AndyRussG moved this task to Triage on the Fundraising-Backlog board.
• AndyRussG subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 2 2015, 3:34 AM
Pcoombe updated the task description. (Show Details)Dec 2 2015, 11:57 AM
Pcoombe set Security to None.
• MeganHernandez_WMF added subscribers: Pcoombe, • atgo, • MeganHernandez_WMF.Dec 2 2015, 1:38 PM

Hey @AndyRussG, @Pcoombe & @atgo

Thanks for looking into this. Bummer there's not an easy way to do this in the banner, we thought there would be a simple solution to test it out. Do you have an idea if this would be a significant amount of work? We would like to use it for a test, but I think it might actually be something we would roll out across the campaign. We're getting a lot of banner closes and I think (but don't know for sure how many) of those closes are from people who were busy but who might want to donate later. It could be good for us to be able to better hide banners from people who really don't want to donate and still give a chance to those who do want to donate. If this is the type of thing that could break a bunch on stuff in central notice, let's hold off :) Thanks for your input!

• AndyRussG added a comment.Dec 2 2015, 1:44 PM
In T120056#1844581, @MeganHernandez_WMF wrote:

Do you have an idea if this would be a significant amount of work?
[...]
If this is the type of thing that could break a bunch on stuff in central notice, let's hold off :) Thanks for your input!

Hi! On the contrary, it would be quick, simple and safe, I think! We're already planning a small deploy (to make the 'namespace' hide reason handled by banner history minification) so that could potentially go out at the same time...

• MeganHernandez_WMF added a comment.Dec 2 2015, 1:56 PM

Quick, simple, safe!? That's great to hear. Wow. Need any other info from us?

• atgo added a comment.Dec 2 2015, 2:48 PM

@AndyRussG can you put an estimate on this?

• AndyRussG edited a custom field.Dec 2 2015, 3:37 PM
• AndyRussG claimed this task.Dec 2 2015, 9:15 PM
• AndyRussG added a project: Fundraising Sprint Yo La Tengo.
• DStrine moved this task from Triage to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Dec 2 2015, 9:17 PM
• AndyRussG added a project: Unplanned-Sprint-Work.Dec 2 2015, 9:23 PM
gerritbot subscribed.Dec 3 2015, 1:01 AM

Change 256615 had a related patch set uploaded (by AndyRussG):
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256615

gerritbot added a project: Patch-For-Review.Dec 3 2015, 1:01 AM
• AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Yo La Tengo board.Dec 3 2015, 1:02 AM
• AndyRussG added a comment.Dec 3 2015, 3:21 PM

With this patch, we have a hard-coded 1-month limit to the duration of custom hide cookies, just as a precaution against cookie proliferation.

gerritbot added a comment.Dec 3 2015, 11:30 PM

Change 256615 merged by jenkins-bot:
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256615

gerritbot added a comment.Dec 4 2015, 12:09 AM

Change 256863 had a related patch set uploaded (by AndyRussG):
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256863

gerritbot added a comment.Dec 4 2015, 12:11 AM

Change 256863 merged by jenkins-bot:
ext.centralNotice.display: Add API for custom hide cookie reasons and durations

https://gerrit.wikimedia.org/r/256863

• AndyRussG moved this task from Review to Done on the Fundraising Sprint Yo La Tengo board.Dec 4 2015, 1:41 AM
• AndyRussG closed this task as Resolved.Dec 4 2015, 1:43 AM
• AndyRussG reopened this task as Open.
• AndyRussG closed this task as Resolved.Dec 4 2015, 1:46 AM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits