Maniphest T120139

Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Pols12
	Dec 2 2015, 10:27 PM

Description

T104790: Pasting into a VE surface in Firefox adds spurious line breaks and nowikis has not been really fixed. Indeed, there are now 2 spaces everywhere where there was a line break before.
I think the line breaks should be replaced by the empty string rather than by a space.

(same reproduction method as T104790.

Details

	Subject	Repo	Branch	Lines +/-
	Paste sanitization: Check for whitespace before newlines	VisualEditor/VisualEditor	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned Here: T104790: Pasting into a VE surface in Firefox adds spurious line breaks and nowikis

Event Timeline

Pols12 created this task.Dec 2 2015, 10:27 PM

Pols12 assigned this task to Esanders.

Pols12 raised the priority of this task from to Medium.

Pols12 updated the task description. (Show Details)

Pols12 added projects: VisualEditor, VisualEditor-CopyPaste, Browser-Support-Firefox.

Pols12 added subscribers: Pols12, Trizek-WMF.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2015, 10:27 PM

Please do not assign tasks to developers.

Jdforrester-WMF renamed this task from Pasting into a VE surface in Firefox adds spurious spaces to Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances.Dec 3 2015, 1:32 AM

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

I added a check for whitespace after the newline, but not before...

Change 256620 had a related patch set uploaded (by Esanders):
Paste sanitization: Check for whitespace *before* newlines

https://gerrit.wikimedia.org/r/256620

gerritbot added a project: Patch-For-Review.Dec 3 2015, 1:44 AM

Esanders claimed this task.Dec 3 2015, 1:45 AM

Jdforrester-WMF closed this task as Resolved.Dec 3 2015, 1:55 AM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed Patch-For-Review.

Jdforrester-WMF edited a custom field.

Change 256620 merged by jenkins-bot:
Paste sanitization: Check for whitespace *before* newlines