Page MenuHomePhabricator
Create Task
Maniphest T120295

Setup "official labs grafana" instance
Closed, ResolvedPublic
Actions

Description

Currently the grafana.wikimedia.org installation has no counterpart in the labs infrastructure realm. However, labs does have a working graphite installation on labmon1001.eqiad.wmnet. The installation is used by frontends like nagf (https://tools.wmflabs.org/nagf/) which no matter how nice it is, is not providing the same functionality to labs projects as a dedicated grafana installation would. At the same time, labmon1001 has been added as a data source to the production installation, providing one more argument for the need of a labs grafana install, while at the same time causing some confusion as to how labs projects get to have dashboard at the production installation.

Actionables that IMHO should be implemented:

Get a working grafana installation on labs with a data source pointing to labmon1001
Provide a number of generic dashboards for the various labs projects
Move over to that installation the labs related dashboard that have been created on the production grafana installation
Remove labmon1001 as a data source from the production grafana installation.

11:01 PM <yuvipanda> addshore: there's grafana.wmflabs.org but I've no idea where it's supposed to be running
11:01 PM <addshore> its in the Graphite project
11:01 PM <addshore> grafana.graphite.eqiad.wmflabs
11:02 PM <addshore> It would be cool to get https://github.com/addshore/grafana-wmfpageviews-datasource on it
11:02 PM <yuvipanda> oh
11:02 PM <yuvipanda> addshore: can you file a bug for 'official labs grafana' and I'll set one up from puppet?
11:03 PM <addshore> yes :)
11:04 PM <yuvipanda> addshore: thanks :)

Details

SubjectRepoBranchLines +/-
grafana: Expand edit access in labs grafanaoperations/puppetproduction+1 -1
cache: Add labs grafana behind misc varnishoperations/puppetproduction+13 -1
Add grafana-labs and grafana-labs-admin domainsoperations/dnsmaster+2 -0
grafana: Add and provision labs grafana roleoperations/puppetproduction+24 -1
grafana: Refactor production role into base roleoperations/puppetproduction+209 -186
grafana: Mark role explicitly as productionoperations/puppetproduction+3 -3
grafana: Make role explicitly reference production secretsoperations/puppetproduction+3 -3
Add new secrets for grafana labs / prod instanceslabs/privatemaster+10 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Dec 3 2015, 10:05 PM
Addshore assigned this task to yuvipanda.
Addshore raised the priority of this task from to Needs Triage.
Addshore updated the task description. (Show Details)
Addshore added projects: Grafana, Cloud-Services.
Addshore subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 3 2015, 10:05 PM
Addshore added a parent task: T120298: Install WmfPageview datasource plugin on Labs Grafana install.Dec 3 2015, 10:07 PM
• chasemp triaged this task as Medium priority.Dec 7 2015, 8:12 PM
• chasemp subscribed.
yuvipanda removed yuvipanda as the assignee of this task.Jan 20 2016, 6:24 PM
yuvipanda subscribed.

Unfortunately I don't think I'll have time to do this anytime soon :(

Luke081515 moved this task from Triage to Backlog on the Cloud-Services board.Mar 25 2016, 4:21 PM
yuvipanda added a comment.Apr 1 2016, 11:56 PM

So I just found out that you can use stats from graphite.wmflabs.org on grafana.wmflabs.org - you can switch 'data sources' with the small icon at the bottom right of each graph config. So am using that now.

Krenair subscribed.Apr 16 2016, 6:29 PM

Does that obsolete this task?

yuvipanda added a comment.Apr 16 2016, 6:30 PM

The answer is 'it depends' I think since edit rights on the grafana.wikimedia.org instance are restricted to a particular LDAP group.

Addshore added a comment.Apr 17 2016, 9:17 AM

Also my primary case for a labs instance would be to test out new datasource plugins!
Which I guess we are not okay doing on the production version.

akosiaris merged a task: T137216: Provide a grafana installation for labs.Jul 1 2016, 9:35 AM
akosiaris updated the task description. (Show Details)
akosiaris set Security to None.
akosiaris added subscribers: hashar, Andrew, fgiunchedi and 3 others.
hashar added a comment.Jul 1 2016, 10:28 AM

I welcome the idea of a Grafana instance dedicated to labs, on the other hand I would like to keep the labs datasource on the production instance. The rational is CI is split between production machines and labs instances to run the tests.

A concrete example is easily switching between the production service Zuul board and the integation labs project overview. That is a quite unique use case though, so I am not going to obsess over it ;-}

gerritbot subscribed.Jul 20 2016, 1:05 PM

Change 299999 had a related patch set uploaded (by Yuvipanda):
grafana: Make role explicitly reference production secrets

https://gerrit.wikimedia.org/r/299999

gerritbot added a project: Patch-For-Review.Jul 20 2016, 1:05 PM
yuvipanda mentioned this in rOPUP48e7ec9b53f7: grafana: Make role explicitly reference production secrets.Jul 20 2016, 1:07 PM
yuvipanda mentioned this in rOPUP5ff8549d89e2: grafana: Make role explicitly reference production secrets.Jul 20 2016, 1:12 PM
gerritbot added a comment.Jul 20 2016, 1:20 PM

Change 300004 had a related patch set uploaded (by Yuvipanda):
grafana: Mark role explicitly as production

https://gerrit.wikimedia.org/r/300004

gerritbot added a comment.Jul 20 2016, 1:20 PM

Change 300005 had a related patch set uploaded (by Yuvipanda):
grafana: Refactor production role into base role

https://gerrit.wikimedia.org/r/300005

yuvipanda mentioned this in rOPUP36428549aca2: grafana: Mark role explicitly as production.Jul 20 2016, 1:22 PM
yuvipanda mentioned this in rOPUP0a8dc4595a24: grafana: Refactor production role into base role.
gerritbot added a comment.Jul 20 2016, 1:40 PM

Change 300007 had a related patch set uploaded (by Yuvipanda):
Add new secrets for grafana labs / prod instances

https://gerrit.wikimedia.org/r/300007

yuvipanda mentioned this in rOPUP522e8694c35a: grafana: Refactor production role into base role.Jul 20 2016, 1:40 PM
gerritbot added a comment.Jul 20 2016, 1:41 PM

Change 300007 merged by Yuvipanda:
Add new secrets for grafana labs / prod instances

https://gerrit.wikimedia.org/r/300007

gerritbot added a comment.Jul 20 2016, 1:43 PM

Change 299999 merged by Yuvipanda:
grafana: Make role explicitly reference production secrets

https://gerrit.wikimedia.org/r/299999

yuvipanda mentioned this in rOPUPd74b49bc37ea: grafana: Make role explicitly reference production secrets.Jul 20 2016, 1:45 PM
yuvipanda mentioned this in rOPUP7ad983269a73: grafana: Refactor production role into base role.
gerritbot added a comment.Jul 20 2016, 1:45 PM

Change 300004 merged by Yuvipanda:
grafana: Mark role explicitly as production

https://gerrit.wikimedia.org/r/300004

yuvipanda mentioned this in rOPUPa1e4f743633d: grafana: Mark role explicitly as production.Jul 20 2016, 1:49 PM
yuvipanda mentioned this in rOPUP17357ee19776: grafana: Refactor production role into base role.
yuvipanda mentioned this in rOPUP04f33c61d646: grafana: Refactor production role into base role.
gerritbot added a comment.Jul 20 2016, 1:59 PM

Change 300005 merged by Yuvipanda:
grafana: Refactor production role into base role

https://gerrit.wikimedia.org/r/300005

gerritbot added a comment.Jul 20 2016, 2:00 PM

Change 300020 had a related patch set uploaded (by Yuvipanda):
grafana: Add and provision labs grafana role

https://gerrit.wikimedia.org/r/300020

yuvipanda mentioned this in rOPUPb2d68690bdca: grafana: Add and provision labs grafana role.Jul 20 2016, 2:02 PM
gerritbot added a comment.Jul 20 2016, 2:02 PM

Change 300021 had a related patch set uploaded (by Yuvipanda):
cache: Add labs grafana behind misc varnish

https://gerrit.wikimedia.org/r/300021

gerritbot added a comment.Jul 20 2016, 2:04 PM

Change 300023 had a related patch set uploaded (by Yuvipanda):
Add grafana-labs and grafana-labs-admin domains

https://gerrit.wikimedia.org/r/300023

gerritbot added a comment.Jul 20 2016, 2:06 PM

Change 300020 merged by Yuvipanda:
grafana: Add and provision labs grafana role

https://gerrit.wikimedia.org/r/300020

yuvipanda mentioned this in rOPUPa4599efbd09f: cache: Add labs grafana behind misc varnish.Jul 20 2016, 2:07 PM
yuvipanda mentioned this in rOPUPe003500febc8: cache: Add labs grafana behind misc varnish.Jul 20 2016, 2:20 PM
yuvipanda claimed this task.Jul 20 2016, 2:34 PM

This is very close to being done now!

gerritbot added a comment.Jul 20 2016, 3:01 PM

Change 300023 merged by Yuvipanda:
Add grafana-labs and grafana-labs-admin domains

https://gerrit.wikimedia.org/r/300023

gerritbot added a comment.Jul 20 2016, 3:03 PM

Change 300021 merged by Yuvipanda:
cache: Add labs grafana behind misc varnish

https://gerrit.wikimedia.org/r/300021

yuvipanda mentioned this in rOPUP173cafcb6950: cache: Add labs grafana behind misc varnish.Jul 20 2016, 3:08 PM
gerritbot added a comment.Jul 20 2016, 6:34 PM

Change 300076 had a related patch set uploaded (by Yuvipanda):
grafana: Expand edit access in labs grafana

https://gerrit.wikimedia.org/r/300076

gerritbot added a comment.Jul 20 2016, 6:37 PM

Change 300076 merged by Yuvipanda:
grafana: Expand edit access in labs grafana

https://gerrit.wikimedia.org/r/300076

yuvipanda mentioned this in rOPUPd8b0f449721f: grafana: Expand edit access in labs grafana.Jul 20 2016, 6:40 PM
yuvipanda mentioned this in rOPUP6288e4da9440: grafana: Expand edit access in labs grafana.
hashar mentioned this in T140976: labmon1001 renderer requires authentication breaking labs Shinken probes.Jul 21 2016, 8:48 AM

Yesterday spring most probably has broken the labs Shinken that got a 401 trying to reach labmon1001: T140976

yuvipanda added a comment.Jul 21 2016, 2:36 PM

Is setup to allow login to https://grafana-labs-admin.wikimedia.org to anyone who is a member of any labs project. Still can't see the dashboards I save there in https;//grafana-labs.wikimedia.org though.

Addshore added a comment.EditedJul 25 2016, 4:20 PM
In T120295#2420973, @hashar wrote:

I welcome the idea of a Grafana instance dedicated to labs, on the other hand I would like to keep the labs datasource on the production instance.

Yes this makes total sense, and is already possible.

pasted_file (210×401 px, 17 KB)

In T120295#2483441, @yuvipanda wrote:

Is setup to allow login to https://grafana-labs-admin.wikimedia.org to anyone who is a member of any labs project. Still can't see the dashboards I save there in https;//grafana-labs.wikimedia.org though.

This seems very odd...

yuvipanda added a comment.Jul 25 2016, 4:23 PM

@Addshore indeed, it is very odd..

yuvipanda added a comment.Jul 25 2016, 4:24 PM

@hashar the labs grafana also has prod graphite as a data source...

hashar added a comment.Jul 25 2016, 4:52 PM
In T120295#2492510, @yuvipanda wrote:

@hashar the labs grafana also has prod graphite as a data source...

Yup I am well aware about that and I am making use of it. I guess from one of the comment above, I understood the labs source would be dropped. If it is kept available then I have no concern to raise anymore :-}

yuvipanda added a comment.Jul 25 2016, 4:54 PM

@hashar no, I meant the opposite - that the grafana at grafana-labs.wikimedia.org also has access to prod graphite - so you can move dashboards that are using labs graphite + prod graphite from prod grafana to labs grafana. I don't know if we'll keep labs graphite on prod grafana forever - @fgiunchedi might have opinions on that.

fgiunchedi added a comment.Jul 26 2016, 8:52 AM
In T120295#2492682, @yuvipanda wrote:

@hashar no, I meant the opposite - that the grafana at grafana-labs.wikimedia.org also has access to prod graphite - so you can move dashboards that are using labs graphite + prod graphite from prod grafana to labs grafana. I don't know if we'll keep labs graphite on prod grafana forever - @fgiunchedi might have opinions on that.

indeed, once the dashboards graphite-labs as datasource have been moved to grafana-labs I think we should delete the datasource to avoid confusion

akosiaris added a comment.Jul 26 2016, 10:19 AM
In T120295#2494998, @fgiunchedi wrote:
In T120295#2492682, @yuvipanda wrote:

@hashar no, I meant the opposite - that the grafana at grafana-labs.wikimedia.org also has access to prod graphite - so you can move dashboards that are using labs graphite + prod graphite from prod grafana to labs grafana. I don't know if we'll keep labs graphite on prod grafana forever - @fgiunchedi might have opinions on that.

indeed, once the dashboards graphite-labs as datasource have been moved to grafana-labs I think we should delete the datasource to avoid confusion

And I second that approach.

Addshore added a parent task: T119754: Investigate wiki page / wikitext annotation plugin for grafana.Jul 27 2016, 10:52 PM
yuvipanda closed this task as Resolved.Aug 3 2016, 9:10 PM

I'm going to count this as done, and will open a separate ticket for issues.

hashar mentioned this in T146136: Migrate Graphana dashboard "labs-project-board" from prod to labs Graphana instance.Sep 20 2016, 10:32 AM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits