Page MenuHomePhabricator
Create Task
Maniphest T120705

Remove button appears on context menu for MW link nodes, but does not do anything
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

1.Open link inspector
2.Insert an external link
3.Open the context menu for the simple link
4.Click on Remove

It does not do anything, maybe we should remove the node upon clicking on remove button.

Screen Shot 2015-12-07 at 11.41.34 AM.png (120×467 px, 13 KB)

Details

SubjectRepoBranchLines +/-
Switch numbered link context to "delete" instead of "clear"mediawiki/extensions/VisualEditormaster+8 -9
Make clear button on numbered external links remove the nodemediawiki/extensions/VisualEditormaster+10 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Dec 7 2015, 7:45 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 7:45 PM
Jdforrester-WMF renamed this task from Remove link button on context menu does not do anything for simple link to Remove button appears on context menu for MW link nodes, but does not do anything.Dec 8 2015, 8:11 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-MediaWiki-Links.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.
DLynch claimed this task.Dec 9 2015, 4:08 PM
gerritbot subscribed.Dec 9 2015, 4:12 PM

Change 257907 had a related patch set uploaded (by DLynch):
Make clear button on numbered external links remove the node

https://gerrit.wikimedia.org/r/257907

gerritbot added a project: Patch-For-Review.Dec 9 2015, 4:12 PM
Jdforrester-WMF closed this task as Resolved.Dec 9 2015, 4:25 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 9 2015, 4:26 PM

Change 257907 merged by jenkins-bot:
Make clear button on numbered external links remove the node

https://gerrit.wikimedia.org/r/257907

Esanders subscribed.Dec 9 2015, 4:54 PM

We should either change the icon to delete or remove it.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 9 2015, 5:00 PM
gerritbot added a comment.Dec 9 2015, 6:42 PM

Change 257960 had a related patch set uploaded (by DLynch):
Switch numbered link context to "delete" instead of "clear"

https://gerrit.wikimedia.org/r/257960

gerritbot added a project: Patch-For-Review.Dec 9 2015, 6:42 PM
gerritbot added a comment.Dec 14 2015, 1:19 AM

Change 257960 merged by jenkins-bot:
Switch numbered link context to "delete" instead of "clear"

https://gerrit.wikimedia.org/r/257960

Jdforrester-WMF removed a project: Patch-For-Review.Dec 14 2015, 8:40 PM
Ryasmeen added a project: Verified.Dec 14 2015, 9:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL