... and confusingly the results differ from those in view mode.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T94906 [EPIC] Read more related articles after end of current article | |||
| Resolved | None | T122260 [GOAL] Promote related pages to production (on for everyone) on all wikis | |||
| Resolved | Jdlrobson | T116676 Deploy RelatedArticles to all wikipedias (but enabled only in beta) | |||
| Resolved | Jdlrobson | T120735 RelatedArticles shows on editor |
Event Timeline
Comment Actions
... and confusingly the results differ from those in view mode.
We randomly choose 3 items when there are more than 3.
Can you share the URL of the attached screenshot's page? I cannot reproduce this locally. Thanks.
Comment Actions
Can't reproduce locally, however, you shouldn't load the module on pages with action other than view, btw.
Comment Actions
Previously it worked on http://en.wikipedia.beta.wmflabs.org/wiki/Related_test but whilst we are on the train we cannot test on beta labs.
The problem is we don't guard against running in edit mode so if relatedPages.getForCurrentPage( LIMIT ) returns results then it will show.
Comment Actions
Change 258061 had a related patch set uploaded (by Jdlrobson):
Disable RelatedArticles when editor enabled
Comment Actions
Change 258062 had a related patch set uploaded (by Jdlrobson):
Disable RelatedArticles when editor enabled
Comment Actions
There are some comments in the patch. Also the solution is a temporary one as described in the commit message. I think we should re-open the bug and fix it properly.