Page MenuHomePhabricator
Create Task
Maniphest T121369

Thanks: Take advantage of new parameters passed to HistoryRevisionTools and DiffRevisionTools hooks
Closed, ResolvedPublic
Actions

Description

rMW68692ebb6904: Add user and previous rev to HistoryRevisionTools, and user to DiffRevisionTools adds a $user parameter so we no longer need to rely on $wgUser. Yay!

Details

SubjectRepoBranchLines +/-
HistoryRevisionTools and DiffRevisionTools no longer use $wgUsermediawiki/extensions/Thanksmaster+4 -6
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Dec 14 2015, 12:44 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Thanks, good first task.
Legoktm subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 14 2015, 12:44 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Florian added a project: Google-Code-In-2015.Dec 15 2015, 7:32 AM
Florian subscribed.

Sounds like a GCI task? (I would mentor it) :)

• Mattflaschen-WMF subscribed.Dec 15 2015, 11:07 PM

Created at GCI (Stop using $wgUser for Thanks HistoryRevisionTools and DiffRevisionTools).

• Mattflaschen-WMF moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 15 2015, 11:08 PM
Florian added a comment.Dec 16 2015, 7:27 AM

Link to the task: https://codein.withgoogle.com/dashboard/tasks/6741464771985408/

Mhutti1 claimed this task.Dec 21 2015, 9:51 AM
gerritbot subscribed.Dec 21 2015, 10:56 AM

Change 260342 had a related patch set uploaded (by Mhutti1):
HistoryRevisionTools and DiffRevisionTools no longer use $wgUser

https://gerrit.wikimedia.org/r/260342

gerritbot added a project: Patch-For-Review.Dec 21 2015, 10:56 AM
Florian closed this task as Resolved.Dec 21 2015, 7:24 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 21 2015, 8:00 PM
UltrasonicNXT subscribed.Jan 23 2016, 11:25 AM

This is breaking history and diff pages on our site

Argument 4 passed to ThanksHooks::insertThankLink() must be an instance of User, none given in /var/www/core/extensions/Thanks/Thanks.hooks.php on line 43

Florian added a comment.Jan 23 2016, 12:56 PM

See T124532: Thanks extension breaking all history and diff pages

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL