Page MenuHomePhabricator

Thanks: Take advantage of new parameters passed to HistoryRevisionTools and DiffRevisionTools hooks
Closed, ResolvedPublic

Description

rMW68692ebb6904: Add user and previous rev to HistoryRevisionTools, and user to DiffRevisionTools adds a $user parameter so we no longer need to rely on $wgUser. Yay!

Event Timeline

Legoktm created this task.Dec 14 2015, 12:44 AM
Legoktm updated the task description. (Show Details)
Legoktm raised the priority of this task from to Needs Triage.
Legoktm added projects: Thanks, good first bug.
Legoktm added a subscriber: Legoktm.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Florian added a subscriber: Florian.

Sounds like a GCI task? (I would mentor it) :)

Created at GCI (Stop using $wgUser for Thanks HistoryRevisionTools and DiffRevisionTools).

Mhutti1 claimed this task.Dec 21 2015, 9:51 AM

Change 260342 had a related patch set uploaded (by Mhutti1):
HistoryRevisionTools and DiffRevisionTools no longer use $wgUser

https://gerrit.wikimedia.org/r/260342

Florian closed this task as Resolved.Dec 21 2015, 7:24 PM

This is breaking history and diff pages on our site

Argument 4 passed to ThanksHooks::insertThankLink() must be an instance of User, none given in /var/www/core/extensions/Thanks/Thanks.hooks.php on line 43