Page MenuHomePhabricator

Thanks extension breaking all history and diff pages
Closed, InvalidPublic

Description

Argument 4 passed to ThanksHooks::insertThankLink() must be an instance of User, none given in /var/www/core/extensions/Thanks/Thanks.hooks.php on line 43

Looks like the breaking change was https://gerrit.wikimedia.org/r/#/c/260342/

Event Timeline

UltrasonicNXT raised the priority of this task from to Needs Triage.
UltrasonicNXT updated the task description. (Show Details)
UltrasonicNXT added a project: Thanks.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

Sorry should say, we are MW 1.16.2 and thanks 1.2.0 (2ee8d58)

TTO added a subscriber: TTO.Jan 23 2016, 11:33 AM

I'm guessing you mean 1.26.2...

You should be using the REL1_26 branch, then, shouldn't you? That commit was only on master. Master isn't guaranteed to be compatible with old core versions, normally. Is Thanks an exception to that rule of thumb?

Florian closed this task as Invalid.Jan 23 2016, 12:55 PM
Florian claimed this task.

I copy my comment from the gerrit commit (link):

I suspect, that you don't use a wmf-version, so you shouldn't use the latest master branch of the Thanks extension. You need the following commit in your mediawiki/core checkout:
https://phabricator.wikimedia.org/rMW68692ebb69042d0464a92db08340d49f601fd1e4
Btw.: For support request I suggest to use https://www.mediawiki.org/wiki/Project:Support_desk and if you found a bug you could create a task in our phabricator instance: https://phabricator.wikimedia.org :)

What you see is the expected behaviour, please use the supported branches only :) You can get the REL1_26 version from https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Thanks

My apologies guys.