Page MenuHomePhabricator
Create Task
Maniphest T121448

Remove button on link context menu does not work after adding label to a simple link (because it's now the wrong context menu for the item)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page
  2. Insert an external link
  3. Open the context menu
  4. Click on Edit and Add label to the link

5.Now from the context menu click on remove button
6.Go to next line

Observe that, when you click on remove button, it does remove the link from the text but as soon as you go the next line it comes back.

Details

SubjectRepoBranchLines +/-
Select the label properly when converting LinkNode to LinkAnnotationmediawiki/extensions/VisualEditormaster+6 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Dec 14 2015, 9:05 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 14 2015, 9:05 PM
Jdforrester-WMF renamed this task from Remove button on link context menu does not work after adding label to a simple link to Remove button on link context menu does not work after adding label to a simple link (because it's now the wrong context menu for the item).Dec 15 2015, 8:17 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added projects: VisualEditor-MediaWiki-Links, VisualEditor-EditingTools.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot subscribed.Apr 19 2016, 4:37 PM

Change 284223 had a related patch set uploaded (by DLynch):
Select the label properly when converting LinkNode to LinkAnnotation

https://gerrit.wikimedia.org/r/284223

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 4:37 PM
gerritbot added a project: Patch-For-Review.Apr 19 2016, 4:37 PM
DLynch claimed this task.Apr 21 2016, 4:12 PM
gerritbot added a comment.Apr 26 2016, 12:40 PM

Change 284223 merged by jenkins-bot:
Select the label properly when converting LinkNode to LinkAnnotation

https://gerrit.wikimedia.org/r/284223

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)).Apr 26 2016, 1:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 26 2016, 4:08 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL