Page MenuHomePhabricator
Create Task
Maniphest T121488

Formula edits should be discarded if the dialog is cancelled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If a formula is edited in the math dialog, then the cancel button is clicked, the edits are currently not discarded, meaning that when the dialog is reopened the old, cancelled edits are still there.

Mentioned here: https://en.wikipedia.org/w/index.php?title=Wikipedia%3AVisualEditor%2FFeedback&type=revision&diff=695260742&oldid=695259058

Details

SubjectRepoBranchLines +/-
ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editingmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Dec 15 2015, 7:18 AM
Tchanders claimed this task.
Tchanders raised the priority of this task from to Needs Triage.
Tchanders updated the task description. (Show Details)
Tchanders added a project: VisualEditor.
Tchanders subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 15 2015, 7:18 AM
Tchanders set Security to None.Dec 15 2015, 7:23 AM
Tchanders added a subscriber: • Whatamidoing-WMF.
gerritbot subscribed.Dec 15 2015, 2:41 PM

Change 259253 had a related patch set uploaded (by Esanders):
ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing

https://gerrit.wikimedia.org/r/259253

gerritbot added a project: Patch-For-Review.Dec 15 2015, 2:41 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 15 2015, 8:03 PM
Jdforrester-WMF added a project: Math.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added a parent task: T118616: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability.
gerritbot added a comment.Dec 16 2015, 6:44 AM

Change 259253 merged by jenkins-bot:
ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing

https://gerrit.wikimedia.org/r/259253

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 16 2015, 11:00 AM
Jdforrester-WMF closed this task as Resolved.Jan 3 2016, 7:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits