Maniphest T121612

Dismantle the old notification formatter system
Closed, ResolvedPublic
Actions

Description

Get rid of NotificationFormatter and other unused code, and remove unused attributes (like title-message) from notification declarations.

This can be done once the email formatter has been ported to the new system.

Details

	Subject	Repo	Branch	Lines +/-
	Cleanup old notifications config	mediawiki/extensions/EducationProgram	master	+22 -241
	Cleanup old notification config	mediawiki/extensions/OpenStackManager	master	+0 -60
	Cleanup old notification config	mediawiki/extensions/ContentTranslation	master	+0 -16
	Cleanup old notification config	mediawiki/extensions/PageTriage	master	+0 -84
	Cleanup old notification config	mediawiki/extensions/Thanks	master	+0 -123
	Cleanup old notifications config	mediawiki/extensions/Flow	master	+0 -321
	Remove deprecated formatter	mediawiki/extensions/Echo	master	+68 -371
	Cleanup old notification formatting system	mediawiki/extensions/Echo	master	+24 -2 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		SBisson	T121612 Dismantle the old notification formatter system
		Resolved		SBisson	T121067 Write email formatter that uses presentation models

Event Timeline

• Catrope created this task.Dec 16 2015, 2:01 AM

• Catrope raised the priority of this task from to Medium.

• Catrope updated the task description. (Show Details)

• Catrope added projects: Notifications, Collaboration-Team-Archive-2015-2016.

• Catrope subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2015, 2:01 AM

• Catrope added a subtask: T121067: Write email formatter that uses presentation models.Dec 16 2015, 2:01 AM

• Catrope moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.Dec 19 2015, 1:22 AM

• Catrope moved this task from Ready for pickup to RFP (cross-wiki notifications) on the Collaboration-Team-Archive-2015-2016 board.Dec 19 2015, 1:40 AM

• Mattflaschen-WMF subscribed.Dec 22 2015, 9:33 PM

• jmatazzoni edited projects, added Collab-Team-2016-Apr-Jun-Q4; removed Collaboration-Team-Archive-2015-2016.Apr 6 2016, 8:51 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.

SBisson claimed this task.Jun 29 2016, 2:48 PM

SBisson moved this task from Ready for Pickup to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.

Change 296641 had a related patch set uploaded (by Sbisson):
Cleanup old notification formatting system

https://gerrit.wikimedia.org/r/296641

gerritbot added a project: Patch-For-Review.Jun 29 2016, 8:25 PM

Change 296641 merged by jenkins-bot:
Cleanup old notification formatting system

https://gerrit.wikimedia.org/r/296641

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 19 2016, 11:00 PM

Change 300032 had a related patch set uploaded (by Sbisson):
Remove deprecated formatter

https://gerrit.wikimedia.org/r/300032

Change 300037 had a related patch set uploaded (by Sbisson):
Cleanup old notifications config

https://gerrit.wikimedia.org/r/300037

Change 300042 had a related patch set uploaded (by Sbisson):
Cleanup old notification config

https://gerrit.wikimedia.org/r/300042

Change 300032 merged by jenkins-bot:
Remove deprecated formatter

https://gerrit.wikimedia.org/r/300032

Change 300037 merged by jenkins-bot:
Cleanup old notifications config

https://gerrit.wikimedia.org/r/300037

Change 300042 merged by jenkins-bot:
Cleanup old notification config

https://gerrit.wikimedia.org/r/300042

Change 300066 had a related patch set uploaded (by Sbisson):
Cleanup old notification config

https://gerrit.wikimedia.org/r/300066

Change 300072 had a related patch set uploaded (by Sbisson):
Cleanup old notification config

https://gerrit.wikimedia.org/r/300072

Change 300312 had a related patch set uploaded (by Sbisson):
Cleanup old notification config

https://gerrit.wikimedia.org/r/300312

Change 300312 merged by jenkins-bot:
Cleanup old notification config

https://gerrit.wikimedia.org/r/300312

Change 301810 had a related patch set uploaded (by Sbisson):
Cleanup old notifications config

https://gerrit.wikimedia.org/r/301810

SBisson moved this task from In Development to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 29 2016, 1:33 PM

Change 301810 merged by jenkins-bot:
Cleanup old notifications config

https://gerrit.wikimedia.org/r/301810

Change 300072 merged by jenkins-bot:
Cleanup old notification config

https://gerrit.wikimedia.org/r/300072

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 30 2016, 12:00 AM

SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Aug 1 2016, 11:55 AM

• Mattflaschen-WMF edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collab-Team-2016-Apr-Jun-Q4.Aug 2 2016, 1:15 AM

• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collab-Team-Q1-July-Sep-2016 board.

Checked in betalabs along with T121067: Write email formatter that uses presentation models.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Aug 5 2016, 5:53 PM

• jmatazzoni closed this task as Resolved.Aug 8 2016, 7:38 PM

• jmatazzoni closed subtask T121067: Write email formatter that uses presentation models as Resolved.