Page MenuHomePhabricator
Create Task
Maniphest T123847

Notifications about being mentioned don't point to the section of the mention anymore
Closed, ResolvedPublic
Actions

Description

Before the design of the fly-out menu was changed, the mention notifications pointed to the section where I was mentioned. Right now they point at the begin of the article, I think this should be fixed, that it works as it did before.

Details

SubjectRepoBranchLines +/-
Make the mention notification actually link to the right sectionmediawiki/extensions/Echomaster+2 -1
Customize query in gerrit

Event Timeline

MGChecker created this task.Jan 16 2016, 10:12 PM
MGChecker raised the priority of this task from to Needs Triage.
MGChecker updated the task description. (Show Details)
MGChecker added projects: Notifications, Regression.
MGChecker added subscribers: MGChecker, Luke081515, Aklapper, StudiesWorld.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 16 2016, 10:12 PM
MGChecker renamed this task from Notifications about being mentiones don't point to the section of the mention anymore to Notifications about being mentioned don't point to the section of the mention anymore.Jan 16 2016, 10:12 PM
MGChecker set Security to None.
Legoktm subscribed.Jan 19 2016, 8:06 AM

Yeah, I noticed this too. Should be added as an additional secondary link IMO.

Legoktm edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Jan 19 2016, 8:06 AM
Catrope subscribed.Jan 19 2016, 5:30 PM

Hah, weird. I can confirm that it doesn't work, but I can also see that the code tries to make it work.

Catrope claimed this task.Jan 19 2016, 5:35 PM
gerritbot subscribed.Jan 19 2016, 5:35 PM

Change 264971 had a related patch set uploaded (by Catrope):
Make the mention notification actually link to the right section

https://gerrit.wikimedia.org/r/264971

gerritbot added a project: Patch-For-Review.Jan 19 2016, 5:36 PM
Catrope moved this task from Untriaged to RFP (notifications) on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 5:37 PM
Catrope moved this task from RFP (notifications) to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
gerritbot added a comment.Jan 19 2016, 5:45 PM

Change 264971 merged by jenkins-bot:
Make the mention notification actually link to the right section

https://gerrit.wikimedia.org/r/264971

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 19 2016, 6:00 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jan 20 2016, 1:26 AM
Etonkovidova subscribed.EditedJan 26 2016, 11:56 PM

Checked locally - clicking on Mention notification directs to a topic page with Mention (and to the correct section of the topic).

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jan 26 2016, 11:58 PM
• jmatazzoni closed this task as Resolved.Feb 16 2016, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL