Page MenuHomePhabricator

Claim new method has_source
Open, MediumPublic

Description

claimit has 'exists' detection for sources and qualifiers, however the algorithm it uses does not work.
Claim needs new methods has_source(s) and has_qualifier(s).

T76547 already added has_qualifier.

Event Timeline

jayvdb raised the priority of this task from to Medium.
jayvdb updated the task description. (Show Details)

It is a bit unclear what the criteria for a match would be since a source is essentially a list of Claims. Options are:

  1. All provided Claims need to be present in the source.
  2. All provided Claims need to be present in the source, which can additionally contain no other Claims.
  3. Any of the provided Claims are present in the source.

While 2. is the most straight forward it is also the least useful since a source often consists of a Claim pointing to an external source + a Claim giving some time of timestamp. If you are wondering if something is already sourced from imdb do you care about the timestamp?
On the other hand for a source made up by three Claims you might care about two of them but not the third (which would make solution 3 less useful). Lastly if you use solution 1 you risk that two Claim sources give his when you were in fact expecting only a single Claim source.

matej_suchanek renamed this task from Claim new method has_qualifier to Claim new method has_source.Apr 22 2017, 10:01 AM