Page MenuHomePhabricator

[Dev] org.wikipedia.test.EditTaskTest.testEdit is failing again
Closed, ResolvedPublic

Description

Description

testEdit suddenly started failing. No known client side changes should have caused this.

java.lang.RuntimeException: nosuchsection: There is no section 3.
at org.wikipedia.ApiTask.onCatch(ApiTask.java:48)
at org.wikipedia.concurrency.SaneAsyncTask.onPostExecute(SaneAsyncTask.java:44)
at android.os.AsyncTask.finish(AsyncTask.java:602)
at android.os.AsyncTask.access$600(AsyncTask.java:156)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:615)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4424)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
at dalvik.system.NativeStart.main(Native Method)
Caused by: nosuchsection: There is no section 3.
at org.mediawiki.api.json.ApiResult.assertSuccess(ApiResult.java:110)
at org.mediawiki.api.json.ApiResult.asObject(ApiResult.java:81)
at org.wikipedia.editing.EditTask.processResult(EditTask.java:56)
at org.wikipedia.editing.EditTask.processResult(EditTask.java:13)
at org.wikipedia.ApiTask.performTask(ApiTask.java:32)
at org.wikipedia.concurrency.SaneAsyncTask.doInBackground(SaneAsyncTask.java:29)
at org.wikipedia.concurrency.SaneAsyncTask.doInBackground(SaneAsyncTask.java:7)
at android.os.AsyncTask$2.call(AsyncTask.java:264)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:856)

https://integration.wikimedia.org/ci/job/apps-android-wikipedia-periodic-test/301/testReport/junit/org.wikipedia.test/EditTaskTest/testEdit/

Event Timeline

Niedzielski raised the priority of this task from to Medium.
Niedzielski updated the task description. (Show Details)
Niedzielski subscribed.
Niedzielski set Security to None.

This test started failing because the test wiki page was moved. Resolved by moving it back.

org.wikipedia.test.EditTaskTest.testEdit failed in the most recent build: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-periodic-test/328/testReport/junit/org.wikipedia.test/EditTaskTest/testEdit/

Stacktrace

java.lang.RuntimeException: nosuchsection: There is no section 3.
at org.wikipedia.ApiTask.onCatch(ApiTask.java:48)
at org.wikipedia.concurrency.SaneAsyncTask.onPostExecute(SaneAsyncTask.java:44)
at android.os.AsyncTask.finish(AsyncTask.java:602)
at android.os.AsyncTask.access$600(AsyncTask.java:156)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:615)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4424)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
at dalvik.system.NativeStart.main(Native Method)
Caused by: nosuchsection: There is no section 3.
at org.mediawiki.api.json.ApiResult.assertSuccess(ApiResult.java:110)
at org.mediawiki.api.json.ApiResult.asObject(ApiResult.java:81)
at org.wikipedia.editing.EditTask.processResult(EditTask.java:56)
at org.wikipedia.editing.EditTask.processResult(EditTask.java:13)
at org.wikipedia.ApiTask.performTask(ApiTask.java:32)
at org.wikipedia.concurrency.SaneAsyncTask.doInBackground(SaneAsyncTask.java:29)
at org.wikipedia.concurrency.SaneAsyncTask.doInBackground(SaneAsyncTask.java:7)
at android.os.AsyncTask$2.call(AsyncTask.java:264)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:856)

Checked with 2.1.139-alpha-2016-01-29 (Nexus 5 (Android 5.1.1) )

The following observation is not 100% reproducible, but in about 80%:

  • Saved edits are not displayed immediately, and not after page refresh, and not after navigating away and back. Takes noticeable amount of time to make new edits visible.
  • Edit a Saved page; then, open it from Saved pages - the spinner keeps running.

Screenshot_2016-01-29-11-53-32.png (1×1 px, 96 KB)

Saved edits are visible immediately in 2.1.138-r-2016-01-21

Cannot save any edits in 2.1.139-alpha-2016-01-29 (checked onNexus 5 (Android 5.1.1) )

@Etonkovidova, I think this is just T123938 and the edits are going through ok.

org.wikipedia.test.EditTaskTest.testEdit failed

4 realz!?!?!? This was just working!

Ok, I reverted the page move on test wiki again and kicked off another build. Should be fixed.

Yes, it seems that T123938: [Bug] Edits made with mobile content service enabled show old page copy describe the issue correctly. Not sure if the spinning thing for Saved pages deserves a separate bug - looks mild.

I will check CI for the next build(s).

Note: I've changed the Protection status of those pages to be moveable only by admins.

Starting with build #329(and up to the present #333) org.wikipedia.test.EditTaskTest.testEdit is passing.