Bot's site arguments for constructor should be called as keyword argument, not positional
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Jan 28 2016, 7:37 AM

Description

site arguments are handled by Bot class as keyword argument in constructor. It could set a default site if that argument is missing or the actual value is None. Instantiating ReplaceRobot breaks this rule and site argument always must be given. See https://gerrit.wikimedia.org/r/#/c/266321/ PS1

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Bot class arguments for constructor	pywikibot/core	master	+51 -47

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Xqt	T125049 Bot's site arguments for constructor should be called as keyword argument, not positional
		Resolved		Xqt	T125046 Do not set Bot._site to None if we already have a site object

Event Timeline

Xqt created this task.Jan 28 2016, 7:37 AM

Xqt claimed this task.

Xqt raised the priority of this task from to Medium.

Xqt updated the task description. (Show Details)

Xqt added projects: Pywikibot, Pywikibot-replace.py.

Xqt subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 28 2016, 7:37 AM

Xqt added a subtask: T125046: Do not set Bot._site to None if we already have a site object.Jan 28 2016, 7:38 AM

Change 266998 had a related patch set uploaded (by Xqt):
[BREAK][bugfix] Bot class arguments for constructor

https://gerrit.wikimedia.org/r/266998

gerritbot added a project: Patch-For-Review.Jan 28 2016, 9:29 AM

Change 266998 merged by jenkins-bot:
[bugfix] Bot class arguments for constructor

https://gerrit.wikimedia.org/r/266998

Magul removed a project: Patch-For-Review.Nov 15 2016, 8:52 PM

Dalba closed subtask T125046: Do not set Bot._site to None if we already have a site object as Resolved.Aug 23 2018, 10:13 AM

Xqt closed this task as Resolved.Aug 26 2018, 8:20 AM

Bot's site arguments for constructor should be called as keyword argument, not positionalClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Bot's site arguments for constructor should be called as keyword argument, not positional
Closed, ResolvedPublic
Actions

Related Objects
Search...