Page MenuHomePhabricator

Bot's site arguments for constructor should be called as keyword argument, not positional
Closed, ResolvedPublic

Description

site arguments are handled by Bot class as keyword argument in constructor. It could set a default site if that argument is missing or the actual value is None. Instantiating ReplaceRobot breaks this rule and site argument always must be given. See https://gerrit.wikimedia.org/r/#/c/266321/ PS1

Event Timeline

Xqt created this task.Jan 28 2016, 7:37 AM
Xqt claimed this task.
Xqt raised the priority of this task from to Normal.
Xqt updated the task description. (Show Details)
Xqt added a subscriber: Xqt.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 28 2016, 7:37 AM

Change 266998 had a related patch set uploaded (by Xqt):
[BREAK][bugfix] Bot class arguments for constructor

https://gerrit.wikimedia.org/r/266998

Change 266998 merged by jenkins-bot:
[bugfix] Bot class arguments for constructor

https://gerrit.wikimedia.org/r/266998

Xqt closed this task as Resolved.Aug 26 2018, 8:20 AM