Page MenuHomePhabricator
Create Task
Maniphest T125231

Make language identification for a code block case insensitive in VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Original report

On this article, there is a section with a C language example. The wikitext for this example is <syntaxhighlight lang="C"> instead of <syntaxhighlight lang="c">. Result: the code block is not displayed while editing with VE.

I've reproduced it on a non-RTL language wiki.

Details

SubjectRepoBranchLines +/-
Make VE language checking case-insensitivemediawiki/extensions/SyntaxHighlight_GeSHimaster+2 -2
Customize query in gerrit

Event Timeline

Trizek-WMF created this task.Jan 29 2016, 6:17 PM
Trizek-WMF raised the priority of this task from to Needs Triage.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF added a project: VisualEditor.
Trizek-WMF subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 29 2016, 6:17 PM
Jdforrester-WMF triaged this task as Low priority.Feb 2 2016, 7:44 PM
Jdforrester-WMF added a project: SyntaxHighlight.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF moved this task from Backlog to Accepted on the SyntaxHighlight board.Sep 20 2016, 10:34 PM
Krinkle renamed this task from Language identification for a code block is case sensitive: some blocks disappear while editing with VE to Make language identification for a code block is case insensitive in VE.Apr 28 2017, 9:43 PM
matmarex subscribed.Oct 23 2018, 4:17 AM

This is still a problem, although less severe: the code block appears in VE and can be edited, but after opening the dialog, the language name is considered invalid and you can't apply changes in the dialog until you "fix" it.

matmarex added a project: Google-Code-in-2018.Oct 23 2018, 4:21 AM

I would like to mentor this task in Google-Code-in-2018.

matmarex moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.EditedOct 23 2018, 5:47 AM

https://codein.withgoogle.com/tasks/6009549489176576/

ptrcnull renamed this task from Make language identification for a code block is case insensitive in VE to Make language identification for a code block case insensitive in VE.Oct 24 2018, 3:51 PM
gerritbot subscribed.Oct 24 2018, 6:01 PM

Change 469453 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bjornskjald):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make VE language checking case-insensitive

https://gerrit.wikimedia.org/r/469453

gerritbot added a project: Patch-For-Review.Oct 24 2018, 6:01 PM
gerritbot added a comment.Oct 24 2018, 6:13 PM

Change 469453 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Make VE language checking case-insensitive

https://gerrit.wikimedia.org/r/469453

matmarex closed this task as Resolved.Oct 24 2018, 6:26 PM
matmarex assigned this task to ptrcnull.
matmarex removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 24 2018, 6:26 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 24 2018, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits