[Story] Reduce initialization time of Statementview
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jonas
	Feb 2 2016, 11:56 AM

Description

We would like to reduce initialization time of StatementView and it's sub widgets as it is a main cause of the total render time according to T125502: [Task] Investigate time spent for initialization of individual widgets

Details

	Subject	Repo	Branch	Lines +/-
	Defer sub-widget initialization in statementview	mediawiki/extensions/Wikibase	master	+101 -81
	Defer main snak SnakView initialization	mediawiki/extensions/Wikibase	master	+24 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T59765 Provide JavaScript hook
Resolved	Lydia_Pintscher	T63131 Eliminate or reduce delay between selection of property and displaying of input fields when adding statements
Resolved	None	T58090 Do not change targets to javascript:void(0); on JavaScript load for various "edit" links
Invalid	None	T56098 [Epic][UI] Front-end performance: Improve loading time of items
Resolved	adrianheine	T125503 [Story] Reduce initialization time of Statementview
Resolved	adrianheine	T125502 [Task] Investigate time spent for initialization of individual widgets
Resolved	adrianheine	T125642 [Task] Remove slow $().closest call from snakview
Resolved	None	T125643 [Task] Remove useless drawSnakTypeSelector call in snakview::_create
Resolved	adrianheine	T127316 [Bug] Can not save new quantity statement

Event Timeline

• Jonas created this task.Feb 2 2016, 11:56 AM

• Jonas raised the priority of this task from to Medium.

• Jonas updated the task description. (Show Details)

• Jonas added a project: Wikidata-Sprint-2016-02-02.

• Jonas added subscribers: • Jonas, adrianheine, thiemowmde.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2016, 11:56 AM

Tobi_WMDE_SW raised the priority of this task from Medium to High.Feb 2 2016, 2:10 PM

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-02-02 board.

Tobi_WMDE_SW set Security to None.

• Jonas added a subtask: T125502: [Task] Investigate time spent for initialization of individual widgets.Feb 2 2016, 2:34 PM

• Jonas closed subtask T125502: [Task] Investigate time spent for initialization of individual widgets as Resolved.Feb 3 2016, 1:43 PM

• Jonas added a parent task: T56098: [Epic][UI] Front-end performance: Improve loading time of items.

Agabi10 subscribed.Feb 3 2016, 2:44 PM

Patches for review:

https://github.com/wmde/WikibaseDataModelJavaScript/pull/58
Wikibase-DataModel-JavaScript need a release then, see https://github.com/wmde/WikibaseDataModelJavaScript/milestones/3.0.0.

adrianheine closed subtask T125642: [Task] Remove slow $().closest call from snakview as Resolved.Feb 4 2016, 2:18 PM

• Jonas reopened subtask T125642: [Task] Remove slow $().closest call from snakview as Open.Feb 4 2016, 3:07 PM

• Jonas closed subtask T125643: [Task] Remove useless drawSnakTypeSelector call in snakview::_create as Resolved.Feb 4 2016, 3:25 PM

• Jonas closed subtask T125642: [Task] Remove slow $().closest call from snakview as Resolved.Feb 5 2016, 10:50 AM

matej_suchanek added a project: Wikidata.Feb 8 2016, 9:47 PM

Patch merged, https://github.com/wmde/WikibaseDataModelJavaScript/milestones/3.0.0 still to be done.

Change 269401 had a related patch set uploaded (by Adrian Lang):
Defer main snak SnakView initialization

https://gerrit.wikimedia.org/r/269401

Change 269401 merged by jenkins-bot:
Defer main snak SnakView initialization

https://gerrit.wikimedia.org/r/269401

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-02-16.Feb 11 2016, 11:20 AM

Change 269962 had a related patch set uploaded (by Adrian Heine):
Defer sub-widget initialization in statementview

https://gerrit.wikimedia.org/r/269962

I'd consider this done when the last linked change is merged. It reduces loading time of big items by around 50% for me.

adrianheine moved this task from Backlog to Review on the Wikidata-Sprint-2016-02-02 board.Feb 11 2016, 2:27 PM

Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2016-02-16 board.Feb 16 2016, 1:50 PM

Change 269962 merged by jenkins-bot:
Defer sub-widget initialization in statementview

https://gerrit.wikimedia.org/r/269962

Lydia_Pintscher closed this task as Resolved.Feb 18 2016, 11:21 AM

Lydia_Pintscher claimed this task.

Lydia_Pintscher reassigned this task from Lydia_Pintscher to adrianheine.

Lydia_Pintscher moved this task from Review to Done on the Wikidata-Sprint-2016-02-16 board.

Lydia_Pintscher subscribed.

We have a bug.

• Jonas moved this task from Done to Backlog on the Wikidata-Sprint-2016-02-16 board.Feb 18 2016, 3:16 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Feb 19 2016, 9:49 AM

adrianheine closed subtask T127316: [Bug] Can not save new quantity statement as Resolved.Feb 23 2016, 8:35 AM

adrianheine closed this task as Resolved.Feb 23 2016, 9:07 AM

adrianheine moved this task from Backlog to Done on the Wikidata-Sprint-2016-02-16 board.

[Story] Reduce initialization time of StatementviewClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

[Story] Reduce initialization time of Statementview
Closed, ResolvedPublic
Actions

Related Objects
Search...