Page MenuHomePhabricator

Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits which have no content beyond the auto-placed section name
Closed, DuplicatePublic1 Story Points

Description

As an editor who has enabled the user preference for Prompt me when entering a blank edit summary (wpforceeditsummary),
if I edit a page-section with visual editor,
I want to be prompted/reminded, if I click "Save page" in the "Review your changes" window, if I didn't enter any text as an edit summary in the previous window.

Event Timeline

Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added a project: VisualEditor.
Quiddity added a subscriber: Quiddity.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 11 2016, 12:18 AM
Quiddity renamed this task from Visualeditor should follow my wpuseeditwarning settings in the "Review your changes" window to Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window.Feb 11 2016, 12:18 AM
Quiddity set Security to None.

This seems to work as expected for me. Can you explain what isn't happening?

Quiddity renamed this task from Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window to Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits.Feb 11 2016, 1:53 AM
Quiddity updated the task description. (Show Details)

This seems to work as expected for me. Can you explain what isn't happening?

Aha, this is only a problem for section edits. The wikitext editor still prompts me, even if it's prefilled with /* test */
but visual editor does not. Tested/confirmed at https://en.wikipedia.org/wiki/User:Quiddity/sandbox

Jdforrester-WMF renamed this task from Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits to Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits which have no content beyond the auto-placed section name.Feb 16 2016, 8:17 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

Change 272312 had a related patch set uploaded (by Wctaiwan):
Warn for empty summary when edit section used

https://gerrit.wikimedia.org/r/272312