Page MenuHomePhabricator

"Prompt me when entering a blank edit summary" preference should also apply to summaries with only the section title
Closed, ResolvedPublic1 Estimated Story Points

Description

Currently when you have the "Prompt me when entering a blank edit summary" preference enabled, you are only warned when submitting with a completely blank summary. The behavior in VE should match that in the wikitext editor, i.e. you should get a warning when the edit summary only contains the prefilled section title, but no manual summary, too.

Event Timeline

Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added a subscriber: Schnark.

Well, I'm not going to provide a patch for this, but it should be really easy:

Just replace the check for the empty string in line 1445 in ve.init.mw.Target.js with something like

/^(?:\/\*.*\*\/)?\s*$/.test( saveOptions.summary )
xSavitar set Security to None.
xSavitar added a subscriber: xSavitar.

Will just submit a patch for this at once. I will make sure to test too before submitting to make sure it works. :)

Change 244439 had a related patch set uploaded (by D3r1ck01):
Blank Edit summary prompt Fix

https://gerrit.wikimedia.org/r/244439

(Thank you, in the meantime!)

You are welcome Elitre. I always do my best to make sure these annoying little bugs are fixed ASAP :)

Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

I have submitted a patch for this bug, its still pending, can someone look at it please? :)

There is an unaddressed comment on the change. I should not have to go around marking such changes as CR-1 to get people to pay attention to my comments.

Change 244439 abandoned by D3r1ck01:
Blank Edit summary prompt Fix

Reason:
Some one else will work on this one.

https://gerrit.wikimedia.org/r/244439

Change 272312 had a related patch set uploaded (by Wctaiwan):
Warn for empty summary when edit section used

https://gerrit.wikimedia.org/r/272312

Change 272312 merged by jenkins-bot:
Warn for empty summary when edit section used

https://gerrit.wikimedia.org/r/272312