"Prompt me when entering a blank edit summary" preference should also apply to summaries with only the section title
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently when you have the "Prompt me when entering a blank edit summary" preference enabled, you are only warned when submitting with a completely blank summary. The behavior in VE should match that in the wikitext editor, i.e. you should get a warning when the edit summary only contains the prefilled section title, but no manual summary, too.

Details

	Subject	Repo	Branch	Lines +/-
	Warn for empty summary when edit section used	mediawiki/extensions/VisualEditor	master	+4 -3
	Blank Edit summary prompt Fix	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T52961: VisualEditor: Provide simultaneous access to editor and edit summary

Event Timeline

Schnark created this task.Oct 7 2015, 7:16 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added projects: VisualEditor, VisualEditor-MediaWiki.

Schnark subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2015, 7:16 AM

Troubled.asset subscribed.Oct 7 2015, 8:38 AM

• Elitre mentioned this in T52961: VisualEditor: Provide simultaneous access to editor and edit summary.Oct 7 2015, 12:59 PM

• Elitre subscribed.

Ltrlg subscribed.Oct 7 2015, 6:56 PM

Well, I'm not going to provide a patch for this, but it should be really easy:

Just replace the check for the empty string in line 1445 in ve.init.mw.Target.js with something like

/^(?:\/\*.*\*\/)?\s*$/.test( saveOptions.summary )

Will just submit a patch for this at once. I will make sure to test too before submitting to make sure it works. :)

Change 244439 had a related patch set uploaded (by D3r1ck01):
Blank Edit summary prompt Fix

https://gerrit.wikimedia.org/r/244439

gerritbot added a project: Patch-For-Review.Oct 8 2015, 12:18 PM

(Thank you, in the meantime!)

You are welcome Elitre. I always do my best to make sure these annoying little bugs are fixed ASAP :)

Jdforrester-WMF triaged this task as Low priority.Oct 13 2015, 7:28 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

I have submitted a patch for this bug, its still pending, can someone look at it please? :)

There is an unaddressed comment on the change. I should not have to go around marking such changes as CR-1 to get people to pay attention to my comments.

Change 244439 abandoned by D3r1ck01:
Blank Edit summary prompt Fix

Reason:
Some one else will work on this one.

https://gerrit.wikimedia.org/r/244439

xSavitar removed xSavitar as the assignee of this task.Jan 8 2016, 6:07 PM

Krenair removed a project: Patch-For-Review.Jan 8 2016, 6:09 PM

wctaiwan merged a task: T126562: Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits which have no content beyond the auto-placed section name.Feb 21 2016, 8:32 PM

wctaiwan added subscribers: wctaiwan, Jdforrester-WMF, Quiddity, StudiesWorld.

Change 272312 had a related patch set uploaded (by Wctaiwan):
Warn for empty summary when edit section used

https://gerrit.wikimedia.org/r/272312

gerritbot added a project: Patch-For-Review.Feb 21 2016, 10:47 PM

• AlexMonk-WMF subscribed.Feb 23 2016, 7:46 PM

• AlexMonk-WMF removed a subscriber: Krenair.Feb 23 2016, 7:49 PM