If $wgRCWatchCategoryMembership is true, CategoryMembershipChangeJobs are added even if content type does not have categories
Closed, ResolvedPublic
Actions

Description

For wikidata, this would be a lot of useless jobs for any edits to items or properties.

I think we can add something to ContentHandler, similar to supportsSections, to indicate if the content model supports categories. then check for this before adding the jobs.

Details

Subject	Repo	Branch	Lines +/-
Add EntityHandler::supportsCategories	mediawiki/extensions/Wikibase	wmf/1.28.0-wmf.21	+13 -0
Add EntityHandler::supportsCategories	mediawiki/extensions/Wikibase	master	+13 -0
Add ContentHandler::supportsCategories method	mediawiki/core	master	+19 -0

Customize query in gerrit

Related Objects

Mentioned In: T147748: Large number of CategoryMembershipChangeJob::run updates are failing

Event Timeline

aude created this task.Feb 15 2016, 3:02 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: MediaWiki-Categories, Wikidata.

aude subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 15 2016, 3:02 PM

Change 270749 had a related patch set uploaded (by Aude):
Add ContentHandler::supportsCategories method

https://gerrit.wikimedia.org/r/270749

gerritbot added a project: Patch-For-Review.Feb 15 2016, 3:23 PM

aude claimed this task.Feb 15 2016, 3:25 PM

aude set Security to None.

Lydia_Pintscher added a project: Wikidata-Sprint-2016-02-16.Feb 18 2016, 12:21 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.

Lydia_Pintscher triaged this task as Medium priority.Feb 19 2016, 9:56 AM

Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2016-02-16 board.Mar 1 2016, 11:34 AM

Lydia_Pintscher added a project: Wikidata-Sprint-2016-03-01.Mar 1 2016, 1:55 PM

Change 270749 merged by jenkins-bot:
Add ContentHandler::supportsCategories method

https://gerrit.wikimedia.org/r/270749

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 2 2016, 10:00 PM

@aude @daniel is there still something missing for this, or can this be closed?

matej_suchanek removed a project: Patch-For-Review.Aug 14 2016, 3:55 PM

Change 315070 had a related patch set uploaded (by Hoo man):
Add EntityHandler::supportsCategories

https://gerrit.wikimedia.org/r/315070

gerritbot added a project: Patch-For-Review.Oct 10 2016, 11:22 AM

hoo mentioned this in T147748: Large number of CategoryMembershipChangeJob::run updates are failing.Oct 10 2016, 11:24 AM

Change 315070 merged by jenkins-bot:
Add EntityHandler::supportsCategories

https://gerrit.wikimedia.org/r/315070

Change 315074 had a related patch set uploaded (by Hoo man):
Add EntityHandler::supportsCategories

https://gerrit.wikimedia.org/r/315074

hoo closed this task as Resolved.Oct 10 2016, 11:38 AM

hoo edited projects, added Wikidata-Sprint-2016-09-21; removed Patch-For-Review.

hoo moved this task from Proposed to Done on the Wikidata-Sprint-2016-09-21 board.

Change 315074 merged by jenkins-bot:
Add EntityHandler::supportsCategories