Acceptance criteria
- A forged UA of Mozilla/5.0 (SMART-TV; Linux; Tizen 2.3) AppleWebkit/538.1 (KHTML, like Gecko) SamsungBrowser/1.0 TV Safari/538.1 (specific value matching regex /SMART-TV.*SamsungBrowser/) does not get redirected to mobile
- Product owner is notified, so product owner can update vendor
At the request of the vendor based on user feedback, the default redirect of Samsung Smart TVs to the mobile web should be removed.
UAs matching the regex /SMART-TV.*SamsungBrowser/ should not be redirected to the mobile website.
The current case insensitive regex for "samsung" at https://github.com/wikimedia/operations-puppet/blob/production/templates/varnish/text-frontend.inc.vcl.erb#L22, and https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/4f0db830a8c0e792b944836e201ce07dc47777e2/includes/DeviceDetection.php#L156 is overly broad in its detection/redirection. Likewise, the device detection unit tests probably need an additional test to expressly rule out the smart TVs).
For our future selves, eligible UAs can be identified with the following type of Hive query.
select user_agent, count(*) from webrequest where year = 2016 and month = 2 and day = 14 and agent_type = 'user' and is_pageview = true and user_agent rlike 'SMART-TV.*SamsungBrowser' group by user_agent;