Page MenuHomePhabricator
Create Task
Maniphest T127214

Caching on pageview API should be for 1 day
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Make sure caching headers on pageview API cache results for 1 day.

Related Objects
Search...

Event Timeline

• Nuria created this task.Feb 17 2016, 5:58 PM
• Nuria raised the priority of this task from to High.
• Nuria updated the task description. (Show Details)
• Nuria added projects: Pageviews-API, Analytics-Kanban.
• Nuria subscribed.
Restricted Application added a project: Analytics. · View Herald TranscriptFeb 17 2016, 5:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Nuria added a comment.Feb 17 2016, 6:02 PM

Caching is done on REST base , see if it is possible to be changed only for pageview API

elukey subscribed.Feb 17 2016, 6:04 PM
• Nuria renamed this task from Caching on pageview API should be for 1 day to Caching on pageview API should be for 1 day [1pts].Feb 17 2016, 6:04 PM
• Nuria set Security to None.
• Nuria removed a subscriber: elukey.
• Nuria added a parent task: T126669: Implement a standard page title normalization algorithm (same as mediawiki).Feb 17 2016, 6:08 PM
Milimetric renamed this task from Caching on pageview API should be for 1 day [1pts] to Caching on pageview API should be for 1 day [1 pts].Feb 17 2016, 6:18 PM
Milimetric claimed this task.Feb 18 2016, 4:07 PM
Milimetric moved this task from Next Up to In Progress on the Analytics-Kanban board.
gerritbot subscribed.Feb 18 2016, 4:11 PM

Change 271542 had a related patch set uploaded (by Milimetric):
Increase caching to 1 day

https://gerrit.wikimedia.org/r/271542

gerritbot added a project: Patch-For-Review.Feb 18 2016, 4:11 PM
Milimetric moved this task from In Progress to In Code Review on the Analytics-Kanban board.Feb 18 2016, 4:12 PM
Milimetric removed a project: Analytics.Feb 18 2016, 6:06 PM
Milimetric subscribed.
Restricted Application added a project: Analytics. · View Herald TranscriptFeb 18 2016, 6:06 PM
Milimetric removed a project: Analytics.Feb 18 2016, 6:07 PM
Restricted Application added a project: Analytics. · View Herald TranscriptFeb 18 2016, 6:07 PM
Milimetric removed projects: Analytics, Pageviews-API.Feb 18 2016, 6:07 PM
gerritbot added a comment.Feb 19 2016, 3:57 PM

Change 271542 merged by Milimetric:
Increase caching to 1 day

https://gerrit.wikimedia.org/r/271542

Milimetric renamed this task from Caching on pageview API should be for 1 day [1 pts] to Caching on pageview API should be for 1 day .Feb 22 2016, 8:58 PM
Milimetric moved this task from In Code Review to Done on the Analytics-Kanban board.
Milimetric set the point value for this task to 1.
Milimetric moved this task from Done to In Code Review on the Analytics-Kanban board.Feb 22 2016, 9:15 PM
Milimetric added a subscriber: • Pchelolo.

Assigning to @Pchelolo because he's removing the cache override from the front-end restbase so that aqs can control it.

Milimetric reassigned this task from Milimetric to • Pchelolo.Feb 22 2016, 9:16 PM
• Pchelolo added a comment.Feb 23 2016, 2:38 AM

Created a PR for frontend RESTBase (https://github.com/wikimedia/restbase/pull/523) to pass through any headers sent by AQS without modifications.

• Pchelolo closed this task as Resolved.Mar 2 2016, 4:51 PM

The change is deployed, now AQS if completely responsible for it's response headers. RESTBase doesn't change them any more.

Milimetric added a comment.Mar 2 2016, 5:40 PM

Thank you!

Milimetric moved this task from In Code Review to Done on the Analytics-Kanban board.Mar 2 2016, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits