Page MenuHomePhabricator

Don't hide messages badge when user has never had messages
Closed, ResolvedPublic

Description

We currently hide the messages badge when the user has never had any message-type notifications. That made some sense in a world where all message-type notifications came from Flow, but in today's world it doesn't make much sense any more. edit-user-talk is now in the messages bucket, and we're about to move more things in there. Cross-wiki notifications exist, and so we get bugs like T124372: If user only has foreign messages, the messages badge should not be suppressed. It seems silly to keep jumping through hoops to make this "feature" work. Eliminating this would also help a bit with T127687: Echo makes too many round-trips to memcached.

Event Timeline

Catrope created this task.Feb 22 2016, 6:29 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 22 2016, 6:29 PM

Change 272686 had a related patch set uploaded (by Legoktm):
Always show the messages flyout icon

https://gerrit.wikimedia.org/r/272686

Change 272732 had a related patch set uploaded (by Matthias Mullie):
Delete rows in echo_unread_wikis if there are no unread notifs

https://gerrit.wikimedia.org/r/272732

Change 272686 merged by jenkins-bot:
Always show the messages flyout icon

https://gerrit.wikimedia.org/r/272686

Legoktm closed this task as Resolved.Feb 23 2016, 9:10 PM

Change 272732 merged by jenkins-bot:
Delete rows in echo_unread_wikis if there are no unread notifs

https://gerrit.wikimedia.org/r/272732