Page MenuHomePhabricator
Create Task
Maniphest T128046

[Dev] Image assets should be derived from SVGs by the Android toolchain
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Android Support library v23.2 seems to support vector drawables on all APIs:
http://android-developers.blogspot.com/2016/02/android-support-library-232.html

I'm not sure if we can user our SVGs verbatim but presumably allowing the Android toolchain to cut and optimize our assets from a single source will produce the best result with the least code.

Some more tips here for the platform version of VectorDrawables:
https://medium.com/@webalys/die-png-die-how-to-use-vector-icons-in-your-apps-d884c9c63e93#.e1ji7fz2t

Alternative library from Trellolololo:
https://github.com/trello/victor

Details

SubjectRepoBranchLines +/-
Vector drawables, part 2.apps/android/wikipediamaster+228 -575
Introduction to vector drawables.apps/android/wikipediamaster+45 -195
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.Feb 25 2016, 2:21 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 25 2016, 2:21 AM
• Niedzielski added a subtask: T128126: [Dev] Upgrade Android Support libraries to v23.2.Feb 25 2016, 8:42 PM
Dbrant moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Mar 2 2016, 8:47 PM
Dbrant closed subtask T128126: [Dev] Upgrade Android Support libraries to v23.2 as Resolved.Mar 25 2016, 2:13 PM
gerritbot subscribed.Apr 19 2016, 6:26 PM

Change 284253 had a related patch set uploaded (by Dbrant):
Introduction to vector drawables.

https://gerrit.wikimedia.org/r/284253

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 6:26 PM
gerritbot added a project: Patch-For-Review.Apr 19 2016, 6:26 PM
gerritbot added a comment.Apr 20 2016, 12:30 AM

Change 284379 had a related patch set uploaded (by Dbrant):
Vector drawables, part 2.

https://gerrit.wikimedia.org/r/284379

gerritbot added a comment.Apr 20 2016, 5:34 PM

Change 284253 merged by jenkins-bot:
Introduction to vector drawables.

https://gerrit.wikimedia.org/r/284253

gerritbot added a comment.Apr 20 2016, 6:02 PM

Change 284379 merged by jenkins-bot:
Vector drawables, part 2.

https://gerrit.wikimedia.org/r/284379

Dbrant claimed this task.Apr 20 2016, 6:52 PM
Dbrant set the point value for this task to 3.
Dbrant added a project: Mobile-App-Android-Sprint-80-Mercury.
Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Android-Sprint-80-Mercury board.

QA: no functional changes intended.

Dbrant added a project: Unplanned-Sprint-Work.Apr 20 2016, 6:54 PM
Nicholas.tsg subscribed.Apr 20 2016, 8:46 PM

Testing Wikipedia app 2.1.143-alpha-2016-04-20 on Android 5.1 ZTE phone. No issues uncovered during exploratory testing.

Nicholas.tsg moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Android-Sprint-80-Mercury board.Apr 20 2016, 8:46 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-80-Mercury board.Apr 20 2016, 8:51 PM
Dbrant closed this task as Resolved.Apr 20 2016, 8:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits