Page MenuHomePhabricator

[Regression pre-wmf.15] CapsuleItemWidget delete button is out of place for Firefox users
Closed, ResolvedPublic1 Estimated Story Points

Description

When I load the demo page in Firefox 45.0b5, the buttons are below the expected position. This happens with both the MediaWiki and Apex themes.

Git bisect blames rGOJUd40c796fd11c: CapsuleItemWidget: Tweak styles for the "remove" button, although I wouldn't be too surprised if it was really added in rGOJU3073f76c1a21: OO.ui.CapsuleItemWidget: Use Button instead of an Indicator and just covered up by the large negative margin removed in rGOJUd40c796fd11c.

I note this is going to affect ApiSandbox in production in 1.27.0-wmf.15 (or whichever version rMW1cdee3383553: Update OOjs UI to v0.16.0 goes out with).

Event Timeline

Seems to be Firefox-specific, it looks fine on Chrome:

It'll affect UploadWizard's and cross-wiki upload dialog's category selector too, presumably. I'll look into it next week if no one will have fixed it yet.

I'm not seeing the issue on the demo page, with Firefox 44 on mac.

Change 272647 had a related patch set uploaded (by Bartosz Dziewoński):
CapsuleItemWidget: Revert regression on "remove" button in Firefox

https://gerrit.wikimedia.org/r/272647

matmarex triaged this task as High priority.

Change 272647 merged by jenkins-bot:
CapsuleItemWidget: Revert regression on "remove" button in Firefox

https://gerrit.wikimedia.org/r/272647

Change 273839 had a related patch set uploaded (by Jforrester):
OOjs UI: CapsuleItemWidget: Revert regression on remove button in Firefox

https://gerrit.wikimedia.org/r/273839

Jdforrester-WMF renamed this task from CapsuleItemWidget delete button is out of place to [Regression pre-wmf.15] CapsuleItemWidget delete button is out of place for Firefox users.Feb 29 2016, 12:01 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Volker_E.

Change 273839 merged by jenkins-bot:
OOjs UI: CapsuleItemWidget: Revert regression on remove button in Firefox

https://gerrit.wikimedia.org/r/273839