Maniphest T128980

Undefined property in revision delete for archived rows
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

After T109041 when visiting a archived deleted revision row a php notice is shown:

Notice: Undefined property: stdClass::$ts_tags in \includes\revisiondelete\RevDelRevisionItem.php on line 182

Details

	Subject	Repo	Branch	Lines +/-
	RevDel: Fix ChangeTags for archived items	mediawiki/core	master	+51 -14

Customize query in gerrit

Related Objects

Mentioned Here: T109041: Show change tags on Special:RevisionDelete

Event Timeline

Umherirrender created this task.Mar 5 2016, 10:25 PM

Restricted Application added subscribers: JEumerus, TTO, Aklapper. · View Herald TranscriptMar 5 2016, 10:25 PM

Definitely showing up in 1.27.0-wmf.{17,18}

RevDelArchiveList needs ChangeTags::modifyDisplayQuery . It should work fine despite being in the archive table. See SpecialUndelete.php.

I don't have time to test it right now.

• Mattflaschen-WMF claimed this task.May 19 2016, 9:10 PM

Change 289756 had a related patch set uploaded (by Mattflaschen):
RevDel: Fix ChangeTags for archived items

https://gerrit.wikimedia.org/r/289756

gerritbot added a project: Patch-For-Review.May 19 2016, 9:10 PM

• Mattflaschen-WMF added a project: Collab-Team-2016-Apr-Jun-Q4.May 19 2016, 9:11 PM

• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 19 2016, 9:15 PM

Umherirrender closed this task as Resolved.May 24 2016, 6:33 PM

Change 289756 merged by jenkins-bot:
RevDel: Fix ChangeTags for archived items

https://gerrit.wikimedia.org/r/289756

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), MW-1.28-release-notes.May 31 2016, 9:01 PM

• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:47 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM