Page MenuHomePhabricator

Undefined property in revision delete for archived rows
Closed, ResolvedPublic

Description

After T109041 when visiting a archived deleted revision row a php notice is shown:

Notice: Undefined property: stdClass::$ts_tags in \includes\revisiondelete\RevDelRevisionItem.php on line 182

Event Timeline

Restricted Application added subscribers: JEumerus, TTO, Aklapper. · View Herald TranscriptMar 5 2016, 10:25 PM
thcipriani added a subscriber: thcipriani.

Definitely showing up in 1.27.0-wmf.{17,18}

RevDelArchiveList needs ChangeTags::modifyDisplayQuery . It should work fine despite being in the archive table. See SpecialUndelete.php.

I don't have time to test it right now.

Change 289756 had a related patch set uploaded (by Mattflaschen):
RevDel: Fix ChangeTags for archived items

https://gerrit.wikimedia.org/r/289756

Umherirrender closed this task as Resolved.May 24 2016, 6:33 PM

Change 289756 merged by jenkins-bot:
RevDel: Fix ChangeTags for archived items

https://gerrit.wikimedia.org/r/289756