Ensure lazy-created image retains all attributes
Closed, ResolvedPublic
Actions

Description

Filing as reminder from https://gerrit.wikimedia.org/r/#/c/275670/2/resources/mobile.startup/Skin.js. Right now ~~the srcset width and height~~ class attributes are missing from the javascript-created image. ~~Which causes it to render at the wrong dimensions if the image dimensions vary from the original.~~

This is the case in at least two scenarios:

HiDPI srcset.
Images smaller than the desired thumbnail size (blown up intentionally by the author).

Details

	Subject	Repo	Branch	Lines +/-
	Pass class to the lazy loaded image	mediawiki/extensions/MobileFrontend	master	+2 -1
	Use the src attribute Luke	mediawiki/extensions/MobileFrontend	master	+15 -5

Customize query in gerrit

Related Objects

Mentioned Here: T130652: Lazy loaded images: border-radius retained when images lazy loaded

Event Timeline

Krinkle created this task.Mar 8 2016, 12:42 AM

Krinkle edited projects, added Reading-Web-Sprint-67-If, Then, Else...?; removed Reading-Web-Sprint-68-"Java and JavaScript are basically the same".Mar 8 2016, 12:49 AM

Change 275670 had a related patch set uploaded (by Jdlrobson):
Use the src attribute Luke

https://gerrit.wikimedia.org/r/275670

gerritbot added a project: Patch-For-Review.Mar 8 2016, 1:03 AM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 8 2016, 6:12 PM

Jdlrobson claimed this task.Mar 8 2016, 10:03 PM

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 10 2016, 1:20 PM

• bmansurov moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 10 2016, 5:49 PM

Change 275670 merged by jenkins-bot:
Use the src attribute Luke

https://gerrit.wikimedia.org/r/275670

Jdlrobson closed this task as Resolved.Mar 10 2016, 6:40 PM

dr0ptp4kt moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 10 2016, 11:20 PM

It's also missing a class attribute (set to thumbimage) which may result in a style regression.

It also seems like a spurious border-radius rule remains active even after the image has finished loading which results in a rendering difference between lazyload vs non-lazyload.

Jdlrobson removed a project: Reading-Web-Sprint-67-If, Then, Else...?.Mar 14 2016, 11:22 PM

Change 277570 had a related patch set uploaded (by Jdlrobson):
Pass class to the lazy loaded image

https://gerrit.wikimedia.org/r/277570

dr0ptp4kt added a project: Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay.Mar 16 2016, 6:49 PM

dr0ptp4kt edited projects, added MobileFrontend; removed Web-Team-Backlog.Mar 16 2016, 9:41 PM

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Mar 16 2016, 9:41 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Mar 16 2016, 9:46 PM

phuedx triaged this task as High priority.Mar 17 2016, 5:09 PM

Jdlrobson lowered the priority of this task from High to Low.Mar 17 2016, 5:11 PM

Jdlrobson removed a parent task: T124390: [GOAL] Load images with care.

Jdlrobson renamed this task from Ensure lazy-created image has all relevant attributes to Ensure lazy-created image retains all attributes.Mar 22 2016, 4:17 PM

Jdlrobson updated the task description. (Show Details)