Page MenuHomePhabricator
Create Task
Maniphest T129394

All article external links fail on Wikipedia Zero networks
Closed, ResolvedPublic
Actions

Description

A partner testing yesterday observed that clicking on an external link does not trigger any action. This should bring up the exit interstitial, but no activity occurs. I tested on an iPhone 6s running iOS 9.2.1 (current) with the standard safari browser. I also removed the override for the exit interstitial "Continue and do not warn again" button with the associated URL, and this had no effect on the problem. I also verified this occurs both on m-dot and zero-dot subdomains.

Details

SubjectRepoBranchLines +/-
Fix broken external linksmediawiki/extensions/ZeroBannerwmf/1.27.0-wmf.15+10 -6
Fix broken external linksmediawiki/extensions/ZeroBannerwmf/1.27.0-wmf.16+10 -6
Fix broken external linksmediawiki/extensions/ZeroBannermaster+10 -6
Customize query in gerrit

Event Timeline

• DFoy created this task.Mar 9 2016, 7:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2016, 7:56 PM
dr0ptp4kt triaged this task as Unbreak Now! priority.Mar 9 2016, 8:46 PM
dr0ptp4kt added subscribers: Yurik, Jdlrobson, • jhobs.
• jhobs added a comment.Mar 9 2016, 10:04 PM

Something must have changed in MobileFrontend, but I don't remember seeing anything around this. Here's the error, I'll look into fixing it.

TypeError: ContentOverlay.extend is not a function TypeError: ContentOverlay.extend is not a function
• jhobs claimed this task.Mar 9 2016, 10:05 PM
• jhobs added a project: Reading-Web-Sprint-67-If, Then, Else...?.
• jhobs moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-67-If, Then, Else...? board.
gerritbot subscribed.Mar 9 2016, 11:16 PM

Change 276375 had a related patch set uploaded (by Jhobs):
Fix broken external links

https://gerrit.wikimedia.org/r/276375

gerritbot added a project: Patch-For-Review.Mar 9 2016, 11:16 PM
gerritbot added a comment.Mar 9 2016, 11:42 PM

Change 276375 merged by jenkins-bot:
Fix broken external links

https://gerrit.wikimedia.org/r/276375

gerritbot added a comment.Mar 10 2016, 12:21 AM

Change 276386 had a related patch set uploaded (by Catrope):
Fix broken external links

https://gerrit.wikimedia.org/r/276386

gerritbot added a comment.Mar 10 2016, 12:21 AM

Change 276387 had a related patch set uploaded (by Catrope):
Fix broken external links

https://gerrit.wikimedia.org/r/276387

gerritbot added a comment.Mar 10 2016, 12:34 AM

Change 276386 merged by jenkins-bot:
Fix broken external links

https://gerrit.wikimedia.org/r/276386

gerritbot added a comment.Mar 10 2016, 12:34 AM

Change 276387 merged by jenkins-bot:
Fix broken external links

https://gerrit.wikimedia.org/r/276387

• jhobs moved this task from Doing to Ready for Signoff on the Reading-Web-Sprint-67-If, Then, Else...? board.EditedMar 10 2016, 1:41 AM

I've confirmed this as fixed on enwiki, but please confirm as well @DFoy so we can signoff.

Jdlrobson closed this task as Resolved.Mar 10 2016, 7:13 PM
Jdlrobson removed a project: Patch-For-Review.
• DFoy added a comment.Mar 11 2016, 6:36 PM

@jhobs @Jdlrobson @dr0ptp4kt
I've tested and confirmed the fix. Thanks everyone for the quick response!

• jhobs moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 14 2016, 4:10 PM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)), MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Mar 14 2016, 9:02 PM
• Phabricator_maintenance moved this task from Incoming to 2015-16 Q3 on the Web-Team-Backlog board.Mar 7 2018, 1:04 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 7 2018, 1:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL