Page MenuHomePhabricator
Create Task
Maniphest T129541

[Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Insert an inline image
  2. Change its position to center/right

The context menu along with the highlight of the image stays at the previous position.

Screen Shot 2016-03-10 at 11.42.01 AM.png (312×872 px, 105 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (7a8829509)mediawiki/extensions/VisualEditormaster+11 -5
FocusableNode: Redraw highlights using focus toggleVisualEditor/VisualEditormaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 10 2016, 7:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2016, 7:43 PM
Jdforrester-WMF triaged this task as High priority.Mar 10 2016, 11:43 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Danny_B added a project: Regression.May 8 2016, 2:11 PM
Jdforrester-WMF renamed this task from [Regression pre-wmf.17] The highlight and the context menu for an inline image stays at the previous position after repositioning it to [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it .May 10 2016, 1:10 AM
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF set the point value for this task to 8.
Esanders subscribed.Aug 25 2017, 2:34 PM

Looks like a regression from https://gerrit.wikimedia.org/r/#/c/270750/

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 2:34 PM
gerritbot subscribed.Aug 25 2017, 2:44 PM

Change 373900 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] FocusableNode: Redraw highlights using focus toggle

https://gerrit.wikimedia.org/r/373900

gerritbot added a project: Patch-For-Review.Aug 25 2017, 2:44 PM
gerritbot added a comment.Aug 28 2017, 3:13 PM

Change 373900 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FocusableNode: Redraw highlights using focus toggle

https://gerrit.wikimedia.org/r/373900

gerritbot added a comment.Aug 31 2017, 6:14 PM

Change 375045 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7a8829509)

https://gerrit.wikimedia.org/r/375045

Esanders merged a task: T174846: VE: Ghost rectangle after changing image alignment.Sep 4 2017, 7:36 PM
Esanders merged a task: T174846: VE: Ghost rectangle after changing image alignment.
Esanders added a subscriber: • Prtksxna.
• Deskana changed the point value for this task from 8 to 1.Sep 5 2017, 10:25 AM
gerritbot added a comment.Sep 5 2017, 7:39 PM

Change 375045 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7a8829509)

https://gerrit.wikimedia.org/r/375045

• Deskana closed this task as Resolved.Sep 5 2017, 9:38 PM
• Deskana assigned this task to Esanders.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 5 2017, 9:38 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Sep 5 2017, 11:47 PM
Jdforrester-WMF added a project: MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)).Sep 13 2017, 3:37 PM
Ryasmeen added a project: Verified-in-Phase0.Sep 14 2017, 3:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits