It has not been turned off yet, but i'm imagining that it can be once we evaluate the new data coming in.

I don't think this is a sufficiently defined task. Which metrics precisely are we meant to surface that we are currently not?

As it is described, I think this is actually a task asking us to switch our Desktop-related metrics from Schema:Search to Schema:AutocompleteSatisfaction? Also it seems like we would benefit from having a second zero results rate on the dashboard that is derived from AutocompleteSatisfaction, rather than Cirrus request logs.

In T129564#2130830, @mpopov wrote:

I don't think this is a sufficiently defined task.

Well, if you think it is not, then by definition it is not! :-) Let's figure out these details in our analysis meeting which is (fortunately) taking place in 25 minutes.

In T129564#2130830, @mpopov wrote:

As it is described, I think this is actually a task asking us to switch our Desktop-related metrics from Schema:Search to Schema:AutocompleteSatisfaction?

Yes, having thought about it more I guess that is what I'm asking. Let's make this task for that.

Also it seems like we would benefit from having a second zero results rate on the dashboard that is derived from AutocompleteSatisfaction, rather than Cirrus request logs.

That sounds worthwhile, but should be in a separate task for that.

I just realized that there's a component that Schema:Search has that Schema:TestSearchSatisfaction2 doesn't: time to display results, which means we can't switch the data scripts to the new schema because that'd stop the data used for http://discovery.wmflabs.org/metrics/#desktop_load

@EBernhardson: do you think we can add a "time it took to display SERP" field for the action=searchResultPage events? How doable is that?

Doesn't look like it's too hard, should be a couple hours work

In T129564#2196304, @EBernhardson wrote:

Doesn't look like it's too hard, should be a couple hours work

I need to file a task for that and put it in the backlog for search. I'll do that after this meeting.

In T129564#2200673, @Deskana wrote:

I need to file a task for that and put it in the backlog for search. I'll do that after this meeting.

Done: T132516: Add time to display results to logging in Schema:TestSearchSatisfaction2

Will be able to continue this after T134319 is done.

Erik said the patch in T132516 should be out by next Thursday.

Note to self that this will require us to update the reference to the TestSearchSatisfaction2 table in the data retrieval codebase for dashboards.

SELECT min(event_msToDisplayResults) FROM TestSearchSatisfaction2_15700292; gives -1473820578422

So I think we're still stalled on this because there appears to be a bug in calculating time to display results.

hmm, basically at this point i am trusting users browsers + clocks to return sane values ... will look closer to see what can be done.

Hey @EBernhardson - how're you doing on this? :)

patch has been merged from T132516, will be deployed everywhere tomorrow as part of the train rollout. There is an open question from Krinkle about if the particular timing chosen is the right one.

Change 298891 had a related patch set uploaded (by Bearloga):
Switch Desktop data from Schema:Search to Schema:TSS2

https://gerrit.wikimedia.org/r/298891

Change 298891 merged by Bearloga:
Switch Desktop data from Schema:Search to Schema:TSS2

https://gerrit.wikimedia.org/r/298891

Change 298905 had a related patch set uploaded (by Bearloga):
Annotate Desktop schema switch

https://gerrit.wikimedia.org/r/298905

Change 298905 merged by Bearloga:
Annotate Desktop schema switch

https://gerrit.wikimedia.org/r/298905

Switched to using TestSearchSatisfaction2 instead of Search schema for Desktop event counts and load times data. Let's keep Search up for another week or so just in case something isn't working as it should. Annotations have been deployed to the beta version, but not production: http://discovery-beta.wmflabs.org/metrics/

it's been about a week, how are we feeling about turning off Schema:Search?

In T129564#2476020, @EBernhardson wrote:

it's been about a week, how are we feeling about turning off Schema:Search?

@mpopov How are things looking?

@Deskana @EBernhardson Looks like it's OK to turn it off… (see: http://discovery.wmflabs.org/metrics/#desktop_events & http://discovery.wmflabs.org/metrics/#desktop_load)