Page MenuHomePhabricator
Create Task
Maniphest T130499

API sandbox's PageLayout looks wrong on a full page
Closed, ResolvedPublic
Actions

Description

T129157 resizes the page layout to fit the current height, but that is a hack solution - such a layout isn't really appropriate outside of a fixed height dialog so we should consider other approaches. There probably shouldn't be a border around it either.

Details

SubjectRepoBranchLines +/-
ApiSandbox: Remove full page bordermediawiki/coremaster+2 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Mar 20 2016, 12:03 PM
Esanders added a subscriber: matmarex.
Esanders renamed this task from API sandbox's shouldn't use PageLayout to API sandbox's PageLayout looks wrong on a full page.Mar 20 2016, 12:06 PM

Perhaps we could use a continuous page layout with a floating TOC (the sidebar). This would also address T130497

matmarex added a comment.Mar 20 2016, 12:09 PM

Yeah, I agree that T129157 is a pretty meh solution to this (and I ran into a couple of very annoying problems with it, related to OOUI not being clever enough about scrollbars). The problem is that MenuLayout/BookletLayout works only when absolutely positioned (T98141).

Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-Action-API board.Mar 22 2016, 1:21 PM
matmarex added a comment.Sep 25 2017, 7:14 PM

I'm not sure what this task is about, actually. Is this a duplicate of T129157?

Esanders added a comment.EditedApr 24 2018, 4:45 PM

With T129157 fixed it isn't that bad, but my other objection was having the majority of the page content framed. Should probably be more like https://en.wikipedia.org/wiki/Special:Notifications

gerritbot added a comment.Oct 22 2020, 11:13 AM

Change 635803 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] ApiSandbox: Remove full page border

https://gerrit.wikimedia.org/r/635803

Restricted Application added a project: Platform Engineering. · View Herald TranscriptOct 22 2020, 11:13 AM
gerritbot added a project: Patch-For-Review.Oct 22 2020, 11:13 AM
gerritbot added a comment.Oct 22 2020, 5:27 PM

Change 635803 merged by jenkins-bot:
[mediawiki/core@master] ApiSandbox: Remove full page border

https://gerrit.wikimedia.org/r/635803

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 22 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2020, 6:20 PM
matmarex closed this task as Resolved.Oct 22 2020, 6:50 PM
matmarex assigned this task to Esanders.

Presumably resolved?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL