Page MenuHomePhabricator

Underscores in namespace become plus signs if you switch from app to "view in browser"
Closed, ResolvedPublic1 Estimated Story Points


On the bottom of every page viewed in the app, there's a "view in browser" link. If I click this link, for example to add a section to a user talk page (which doesn't work in the app), user_talk:xy becomes user+ talk:xy.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2016, 9:56 AM
Jonathan_Data triaged this task as Medium priority.Mar 21 2016, 9:57 AM
Tbayer added a subscriber: Tbayer.

Also reported on the dewiki village pump where someone specified it's about the Android app (I can reproduce it there too), hence adding it to the Android backlog

@Jonathan_Data: Thanks for reporting this! Do you plan to work on a patch to fix this (as you assigned the task to yourself)? Do you need any help to get started? :)

@Aklapper: I didn't yet understand what the assigning of a task to someone actually meant.

Jonathan_Data removed Jonathan_Data as the assignee of this task.Apr 18 2016, 5:26 PM
MBinder_WMF set the point value for this task to 1.May 18 2016, 7:28 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 18 2016, 7:28 PM
Jcruz added a subscriber: Jcruz.Jan 2 2017, 12:55 PM

The reason for this is that the Java URLEncoder encodes the url by replacing the space character of "User talk" by "+". To resolve this we can replace the "+" sign with "%20" so that the correct URL can be formed.
I would like to work on this if the suggested fix is correct?

Mholloway assigned this task to Sandaru.Feb 10 2017, 3:43 PM
Mholloway added a subscriber: Mholloway.

It's all yours!

Change 337046 had a related patch set uploaded (by Sandaru):
Fix url encoding error

@Mholloway Thank you very much. I submitted the patch. Please let me know if it need any modifications.

Change 337046 merged by jenkins-bot:
Fix url encoding error

Mholloway closed this task as Resolved.Feb 14 2017, 7:30 PM