Page MenuHomePhabricator

VisualEditor saves section as page text (deleting all other sections)
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Visit https://www.mediawiki.org/w/index.php?title=Wikibugs&action=edit&section=3 while logged out
  2. Realize you're logged out, and log in
  3. VE only loads that section for you to edit
  4. Make a change and hit save, wiping out the rest of the page :(
  5. https://www.mediawiki.org/w/index.php?title=Wikibugs&diff=prev&oldid=2096741

Event Timeline

Legoktm created this task.Apr 11 2016, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2016, 12:47 AM

Sounds to me like you log into an account set to either:

  • Remember last editor, which was VE (?)
  • Always use VE

And then load https://www.mediawiki.org/w/index.php?title=Wikibugs&action=edit&section=3
And get VE with only the section open, which doesn't work as you'd expect right now.

Change 282821 had a related patch set uploaded (by Alex Monk):
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282821

Yes, my preference is set to "Always use VE".

Jdforrester-WMF triaged this task as Unbreak Now! priority.Apr 11 2016, 10:39 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Ick.

I'm not quite sure why the server sends you via the wikitext editor for this yet, but the automatic switch takes place without noticing the value of wpSection.

Change 282822 had a related patch set uploaded (by Jforrester):
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282822

Change 282821 merged by jenkins-bot:
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282821

Change 282822 merged by jenkins-bot:
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282822

Jdforrester-WMF closed this task as Resolved.Apr 11 2016, 11:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.