Page MenuHomePhabricator
Create Task
Maniphest T132309

VisualEditor saves section as page text (deleting all other sections)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Visit https://www.mediawiki.org/w/index.php?title=Wikibugs&action=edit&section=3 while logged out
  2. Realize you're logged out, and log in
  3. VE only loads that section for you to edit
  4. Make a change and hit save, wiping out the rest of the page :(
  5. https://www.mediawiki.org/w/index.php?title=Wikibugs&diff=prev&oldid=2096741

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditorwmf/1.27.0-wmf.20+5 -1Check wpSection before converting textbox contents for use in VE
mediawiki/extensions/VisualEditormaster+5 -1Check wpSection before converting textbox contents for use in VE
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Apr 11 2016, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2016, 12:47 AM
• AlexMonk-WMF added a subscriber: • AlexMonk-WMF.EditedApr 11 2016, 10:27 PM

Sounds to me like you log into an account set to either:

  • Remember last editor, which was VE (?)
  • Always use VE

And then load https://www.mediawiki.org/w/index.php?title=Wikibugs&action=edit&section=3
And get VE with only the section open, which doesn't work as you'd expect right now.

gerritbot added a subscriber: gerritbot.Apr 11 2016, 10:35 PM

Change 282821 had a related patch set uploaded (by Alex Monk):
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282821

gerritbot added a project: Patch-For-Review.Apr 11 2016, 10:35 PM
Legoktm added a comment.Apr 11 2016, 10:38 PM

Yes, my preference is set to "Always use VE".

Jdforrester-WMF triaged this task as Unbreak Now! priority.Apr 11 2016, 10:39 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Ick.

• AlexMonk-WMF added a comment.Apr 11 2016, 10:39 PM

I'm not quite sure why the server sends you via the wikitext editor for this yet, but the automatic switch takes place without noticing the value of wpSection.

gerritbot added a comment.Apr 11 2016, 10:40 PM

Change 282822 had a related patch set uploaded (by Jforrester):
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282822

Jdforrester-WMF added a project: VisualEditor-MediaWiki.Apr 11 2016, 10:41 PM
Jdforrester-WMF merged a task: T130165: Section edit lead to deleting the rest of the page.
Jdforrester-WMF added a subscriber: greg.
• AlexMonk-WMF claimed this task.Apr 11 2016, 10:46 PM
gerritbot added a comment.Apr 11 2016, 10:50 PM

Change 282821 merged by jenkins-bot:
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282821

gerritbot added a comment.Apr 11 2016, 10:56 PM

Change 282822 merged by jenkins-bot:
Check wpSection before converting textbox contents for use in VE

https://gerrit.wikimedia.org/r/282822

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)), MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 11 2016, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 11 2016, 11:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL