Page MenuHomePhabricator

Move new diffs prototype to a Commtech Labs instance
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
DannyH
Apr 11 2016, 6:37 PM
Referenced Files
F3871071: adding space split.jpg
Apr 13 2016, 11:57 PM
F3871063: bingley unified.jpg
Apr 13 2016, 11:57 PM
F3871067: percival pig unified.jpg
Apr 13 2016, 11:57 PM
F3871076: changed split.jpg
Apr 13 2016, 11:57 PM
F3871078: changed unified.jpg
Apr 13 2016, 11:57 PM
F3871073: adding space unified.jpg
Apr 13 2016, 11:57 PM
F3871061: bingley split.jpg
Apr 13 2016, 11:57 PM
F3871065: percival pig split.jpg
Apr 13 2016, 11:57 PM

Description

Move Jon's prototype for improved diffs to http://commtech.wmflabs.org/, as per T121469: Improve diff compare screen

Event Timeline

DannyH set the point value for this task to 1.Apr 11 2016, 6:42 PM
DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.
Niharika renamed this task from Move new diffs prototype to a dedicated Labs instance to Move new diffs prototype to a Commtech Labs instance.Apr 12 2016, 2:00 PM
Niharika claimed this task.
Niharika moved this task from Ready to In Development on the Community-Tech-Sprint board.

Sorry for not getting back to you sooner. Try the latest uploaded patch.

The implementation was previously falling back to wikidiff2. I've updated the patchset to not to do this to avoid confusion.

Thanks! That seems to have worked! :)

Sorry for not getting back to you sooner. Try the latest uploaded patch.

Hi Jon, I see "Split view", "Unified view" and "Unified view (plain)" on the instance but I recall you showed us a diff with lines for mapping text on the side and possibly one more kind of diff view that you were playing around with. Is it possible to get it/them in the patch as well?

Testing the current version, I'm kind of at a loss to say why unified diffs are better than split diffs. It's obvious why they're better for mobile, where you don't have enough space for side-by-side columns. But on desktop, it seems like a toss-up.

Here are some examples.

Individual words changed, it's basically the same:

bingley split.jpg (646×944 px, 598 KB)

bingley unified.jpg (389×954 px, 405 KB)

Longer phrases changed, I think the split diff is clearer:

percival pig split.jpg (583×943 px, 481 KB)

percival pig unified.jpg (497×965 px, 368 KB)

Splitting one paragraph into two, the unified diff doesn't show anything:

adding space split.jpg (669×958 px, 442 KB)

adding space unified.jpg (422×943 px, 414 KB)

Moving a paragraph to a different spot on the page, and changing a few words in that paragraph, it's a toss-up -- neither version flags the changed words:

changed split.jpg (757×1 px, 555 KB)

changed unified.jpg (619×973 px, 627 KB)

So when we show this to people -- what's the benefit that we think people will get from the unified diff? What problem are we solving?