Steps to reproduce:
- Go to Page title option from the menu
2.Select Heading/Page Title
Observe that, two tick marks appearing next to the option, also its not automatically enabling cursor on that line
Steps to reproduce:
2.Select Heading/Page Title
Observe that, two tick marks appearing next to the option, also its not automatically enabling cursor on that line
mediawiki/core : master | OOjs UI: Correct display of MenuToolGroup checkmarks |
oojs/ui : master | Correct styles for MenuToolGroup checkmarks |
Caused by https://gerrit.wikimedia.org/r/#/c/283182/ - MenuToolGroup doesn't set the icon by JS so it never gets the 'oo-ui-iconElement' class.
I feel like we've broken this at least once in the past… The issue is not apparent in OOjs UI demo, because the menu item there does have an icon, and so 'oo-ui-iconElement' class too.
Change 284728 had a related patch set uploaded (by Bartosz Dziewoński):
Correct styles for MenuToolGroup checkmarks
Change 284733 had a related patch set uploaded (by Jforrester):
OOjs UI: Correct display of MenuToolGroup checkmarks
Change 284733 merged by jenkins-bot:
OOjs UI: Correct display of MenuToolGroup checkmarks
Changing the summary, the cursor issue is probably related with https://phabricator.wikimedia.org/T133229