Page MenuHomePhabricator
Create Task
Maniphest T133295

'finishStash(...) is undefined' when uploading with upload dialog
Closed, ResolvedPublic
Actions

Description

Reported on #wikimedia-tech on 2016-04-21:

<abolsutely3> I was trying to upload a replacement image in English Wikipedia yesterday, but it gets stuck on uploading when I hit Save. I was told yesterday there's an error in my JS console?
<abolsutely3> 09:16:06.172 TypeError: finishStash(...) is undefined UP.finishStashUpload/<() load.php:80 .Deferred/promise.then/</</<() load.php:47 jQuery.Callbacks/fire() load.php:45 jQuery.Callbacks/self.add() load.php:45 .Deferred/promise.then/</<() load.php:47 .each() load.php:5 .Deferred/promise.then/<() load.php:47 .Deferred() load.php:47 .Deferred/promise.then() load.php:46 UP.finishStashUpload() load.php:80 mw.Upload.BookletLa

Image attempted: https://www.dropbox.com/s/ycb3k5odvi3tjh2/gb-tm-full-1.jpg?dl=0

note: the problem occurred during the codfw datacenter test

Details

SubjectRepoBranchLines +/-
mediawiki.api.upload: Unbreak finishing stash uploadsmediawiki/corewmf/1.27.0-wmf.21+1 -1
mediawiki.api.upload: Unbreak finishing stash uploadsmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 21 2016, 2:23 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 21 2016, 2:23 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
• MZMcBride subscribed.Apr 21 2016, 2:53 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptApr 21 2016, 2:53 PM
• RobLa-WMF updated the task description. (Show Details)Apr 21 2016, 2:54 PM
matmarex triaged this task as Unbreak Now! priority.Apr 21 2016, 3:37 PM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptApr 21 2016, 3:37 PM
gerritbot subscribed.Apr 21 2016, 3:37 PM

Change 284710 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.api.upload: Unbreak finishing stash uploads

https://gerrit.wikimedia.org/r/284710

gerritbot added a project: Patch-For-Review.Apr 21 2016, 3:37 PM
gerritbot added a comment.Apr 21 2016, 3:49 PM

Change 284710 merged by jenkins-bot:
mediawiki.api.upload: Unbreak finishing stash uploads

https://gerrit.wikimedia.org/r/284710

matmarex added subscribers: MarkTraceur, • demon.Apr 21 2016, 3:52 PM

The uploads go through, but the upload dialog hangs and doesn't show the successful upload :/ This has been broken for the whole week, since 1.27.0-wmf.21 deployment.

There's no SWAT today due to datacenter switchover, but I asked @demon for his special deployment approval and got it. I asked @MarkTraceur to deploy it.

gerritbot added a comment.Apr 21 2016, 3:52 PM

Change 284715 had a related patch set uploaded (by MarkTraceur):
mediawiki.api.upload: Unbreak finishing stash uploads

https://gerrit.wikimedia.org/r/284715

matmarex edited projects, added MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)); removed Patch-For-Review.Apr 21 2016, 3:57 PM
ReleaseTaggerBot added a project: MW-1.27-release-notes.Apr 21 2016, 4:00 PM
gerritbot added a comment.Apr 21 2016, 4:05 PM

Change 284715 merged by jenkins-bot:
mediawiki.api.upload: Unbreak finishing stash uploads

https://gerrit.wikimedia.org/r/284715

matmarex closed this task as Resolved.Apr 21 2016, 4:15 PM

Fixed and deployed.

matmarex mentioned this in T133306: Add EventLogging instrumentation to the upload dialog.Apr 21 2016, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits