Page MenuHomePhabricator
Create Task
Maniphest T133296

Undefined index: recentChangesFlagsRaw in includes/changes/EnhancedChangesList.php on line 268
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Noticed in https://logstash.wikimedia.org/#/dashboard/elasticsearch/hhvm during codfw->eqiad switchover. These messages were on both codfw and eqiad hosts so it seems unlikely that the problem was purely related to the switch.

Notice: Undefined index: recentChangesFlagsRaw in /srv/mediawiki/php-1.27.0-wmf.21/includes/changes/EnhancedChangesList.php on line 268
Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.27.0-wmf.21/includes/changes/EnhancedChangesList.php on line 285

Details

SubjectRepoBranchLines +/-
If $line is empty in EnhancedChangesList, don't try to access parts of arraymediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Apr 21 2016, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2016, 2:39 PM
Krenair subscribed.Apr 21 2016, 2:45 PM
aude merged a task: T134270: Undefined index: recentChangesFlagsRaw in EnhancedChangesList.php on line 268.May 4 2016, 2:26 PM
aude added subscribers: aude, Zppix.
gerritbot subscribed.May 4 2016, 2:51 PM

Change 286857 had a related patch set uploaded (by Aude):
If $line is empty in EnhancedChangesList, don't try to access parts of array

https://gerrit.wikimedia.org/r/286857

gerritbot added a project: Patch-For-Review.May 4 2016, 2:51 PM
gerritbot added a comment.May 4 2016, 4:04 PM

Change 286857 merged by jenkins-bot:
If $line is empty in EnhancedChangesList, don't try to access parts of array

https://gerrit.wikimedia.org/r/286857

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:02 PM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jan 10 2017, 10:54 PM
matej_suchanek edited projects, added TestMe; removed Patch-For-Review.Jan 14 2017, 5:51 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 14 2017, 5:51 PM
Zppix closed this task as Resolved.Apr 3 2017, 9:34 PM
Zppix assigned this task to aude.

Appears to be fixed/deployed/merged. Thanks for the bug report and fix.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits