Page MenuHomePhabricator

Unmerged changes in Gerrit should not autoclose Phabricator tasks
Closed, ResolvedPublic

Description

I noticed a Gerrit change that included in the commit message, "This probably fixes T125323", caused Phabricator to close the task automatically. Though the commit was not merged, Diffusion indicates it is accessible through refs/changes, as is possible when retrieving the change directly from Gerrit using git. (Interestingly, a "Still Importing..." message is shown in place of a diff, which may be a separate issue.)

Either Phabricator should only close the task once the commit is on an actual branch, or the autoclose feature should be disabled for repos set up with Gerrit code review.

Event Timeline

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 28 2016, 4:57 AM
jayvdb added a subscriber: jayvdb.Apr 28 2016, 6:09 AM

This could be the cause of many new actions appearing on T127286 today (and about 10 other tasks ive noticed)

I think that would be autoclose we need to use.

@mmodell is there a way we can disable autoclose temporarily until we migrate to gerrit. Or is there a way to do it only for imported repos.

Paladox edited projects, added Diffusion; removed Phabricator.Apr 28 2016, 7:22 AM
Paladox added a project: Phabricator.
mmodell closed this task as Resolved.Apr 28 2016, 10:05 AM
mmodell claimed this task.